Repository navigation
fix(ilttu): run ilttu-design v0.1.1, built from main - #5
Merged
Merged
Conversation
Pins the wrapper to ilttu-design-v0.1.1, cut from 401b686 on main, and each binary's SHA-256 from its published SHA256SUMS. Bumps the plugin to 0.3.1. Refs asteroid-computing/ilttu#733
Contributor
Author
|
Ready for review: #5, for asteroid-computing/ilttu#733, head What it is
Verified
Not verified
For AJ to know
|
ajbeck
commented
Nov 15, 2026
ajbeck
left a comment
Contributor
Author
There was a problem hiding this comment.
Review of 4283014: approve
The PR repins the wrapper to ilttu-design-v0.1.1 and bumps the plugin to 0.3.1, for asteroid-computing/ilttu#733, as AJ approved in #733's Decided.
Verified:
- The tag
ilttu-design-v0.1.1points to401b686, PR #3's squash-merge commit onmain. - Each of the four pins equals the digest GitHub records for that release asset: darwin-arm64
e51bc8c8…, darwin-amd64008ec1dd…, linux-arm64314715d7…, linux-amd644bd856bb…. - The diff changes only the tag, the four pins and the plugin's version.
For AJ to know: three of the four binaries are stamped vcs.modified=true, because the release workflow builds inside the checkout. Their bytes are still 401b686's, as the session's byte-for-byte reproduction shows. v0.1.0 had the same flaw. PR #4's commit 0251a4b fixes the workflow, so no re-cut is needed.
Not verified:
- I didn't download or run the binaries; the pins were checked against GitHub's asset digests, not files I hashed.
- The wrapper's cold download.
- PR #4, which is reviewed on its own.
ajbeck
added a commit
that referenced
this pull request
Nov 15, 2026
Start release-please's history at #5's merge, so the plugin's first release PR doesn't repeat what 0.3.1 shipped. Fail the build step when git status fails, download SHA256SUMS in a step of its own so the pin script's step has no token in its env, and let a rerun of the pin job succeed once the pin is on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For asteroid-computing/ilttu#733: re-cut
ilttu-designfrommainafter #3's squash merge, and repin the wrapper, so every pinned binary is built from reviewedmain.What changed
plugins/ilttu/bin/ilttu-designpinsilttu-design-v0.1.1and its four SHA-256s, from the release's publishedSHA256SUMS: https://github.com/asteroid-computing/ilttu-plugins/releases/tag/ilttu-design-v0.1.1.The tag
ilttu-design-v0.1.1is on401b686, #3's squash commit onmain, cut as v0.1.0 was, an annotated tag that the release workflow built and published.Verified
SHA256SUMS, and each pinned sum is that file's.vcs.revision=401b6865987fb8fde5e764fd2a30e390f39e8036, andversionprintsilttu-design-v0.1.1.401b686, with the workflow's own steps and Go 1.27.4, makes all four binaries byte for byte.claude plugin validate .,claude plugin validate plugins/ilttu, andgo vetandgo testinilttu-design/.A flaw in the release build, for #4
Three of the four binaries say
vcs.modified=true; darwin-arm64 saysfalse.The workflow builds into
ilttu-design/dist/, inside the checkout, so after the first build Go sees untracked files and marks the next three modified.The bytes are still
401b686's alone, as the reproduction above shows; only the flag is wrong, and v0.1.0 had the same flaw, which is why only its darwin-arm64 build reproduced before.#4's release workflow builds the same way, so I'm fixing it there, to build outside the checkout.
Not verified