Skip to content

Fix review process with new ontology - #336

Merged
vinceblock99 merged 2 commits into
devfrom
fix/triage-review
Nov 15, 2026
Merged

vinceblock99 merged 2 commits into
devfrom
fix/triage-review

Conversation

@leefaus

@leefaus leefaus commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

This pull request introduces support for retrospective publication reviews in the Atomic CLI and related libraries. It adds a new publication_review module to the codebase, updates the intent graph command to accept and process review files for diagnostic context, and improves the rendering and annotation of reviewed changes. The changes also enhance the triage output to better distinguish set-aside (historical) intent dispositions and add new color mappings for review-related classes in the query module.

Support for publication reviews and review context:

  • Added a new publication_review module (atomic-canonical/src/publication_review.rs) defining the schema, parsing, and validation logic for publication reviews, including types such as IntentPin, ChangePin, ReviewSubject, and PublicationReview. This enables the system to handle present-day reviews of retained evidence. [1] [2]
  • Updated the intent graph command (atomic-cli/src/commands/intent/graph.rs) to accept a --review-file argument, allowing users to include an unsigned/signed prepared review as diagnostic context. The review is resolved by the repository service but does not imply approval. [1] [2]
  • Enhanced the RPC layer (atomic-cli/src/commands/rpc.rs) to pass the review document to the repository service, validate the review preview identity, and ensure the review is connected to the selected intent. [1] [2] [3]

User interface and output improvements:

  • Improved annotation and rendering of reviewed changes in the intent graph, making it clear when a change is reviewed (not inferred implementation) and when review scope/evidence is present. [1] [2]
  • Enhanced triage output to display additional information for intents with a icebox (set-aside) status, including historical criteria and reviewer attribution. [1] [2]

CLI and testing enhancements:

  • Added a new PublicationReview subcommand to the triage CLI for preparing, signing, recording, or inspecting retrospective reviews. [1] [2]
  • Expanded tests to cover review context handling and ensure correct behavior when using the --review-file option.

Visual and configuration updates:

  • Added color mappings for new review-related classes in the query module for improved visualization.
  • Enabled the review-shacl feature for the atomic-repository dependency in the CLI.

Documentation and terminology clarifications:

  • Clarified the meaning of the icebox intent status in documentation, emphasizing that it represents a terminal, set-aside disposition with historical evidence, not a current delivery requirement.

@leefaus
leefaus added this pull request to stack #341 November 15, 2026 16:16
The subject scope-completeness rule only recognized includesIntent, but
the resolver pins icebox intents under includesSetAside. A change whose
retained receipts observe an intent that was later set aside could never
pass validation, even when the review intent explicitly reviews it.

Accept either relation for scope completeness. Managed-change coverage
still requires includesIntent, so a set-aside intent cannot stand in as
implementation evidence (covered by the existing
retired_intent_cannot_supply_managed_change_coverage test).

Note: the shapes file participates in profile_hash, so previously signed
reviews will read as stale and need a superseding signature.
@vinceblock99
vinceblock99 marked this pull request as ready for review November 15, 2026 20:29
@vinceblock99
vinceblock99 merged commit 841c09f into dev Nov 15, 2026
10 checks passed
@vinceblock99
vinceblock99 deleted the fix/triage-review branch November 15, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants