Repository navigation
fix(navbar): drop the Babelize default for githubUrl and accept owner/repo shorthand - #79
Merged
Merged
Conversation
…/repo shorthand showGitHub alone linked to this library's own repository. It now renders no button and warns, and githubUrl accepts "owner" or "owner/repo".
sapatmohit
added
bug
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
githubUrldefaulted tohttps://github.com/babelize/babelize-elements, so any app that setshowGitHubwithout a URL shipped a GitHub button pointing at this library.showGitHubwithoutgithubUrlrenders no button and logs aconsole.warn.githubUrlaccepts"owner"or"owner/repo"(alsogithub.com/owner/repo) and expands it to a github.com URL; full URLs, GitHub or not, pass through unchanged.githubUrl.githubUrlwithoutshowGitHub.Type of change
Checklist
bun run lintpassesbun run typecheckpassesbun run testpassesbun run test:packpassesNotes
Behaviour change for apps relying on the old default (their button disappears, with a warning). Treated as a fix: the old default linked to the wrong repository. Ships as
v2.0.1.