Skip to content

Replace grid setup's overwrite warning with a plain notice and clearer prompts - #262

Merged
sanieldalib merged 4 commits into
mainfrom
salib/grid-overwrite-warning
Nov 13, 2026
Merged

sanieldalib merged 4 commits into
mainfrom
salib/grid-overwrite-warning

Conversation

@sanieldalib

@sanieldalib sanieldalib commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

🚀 What

  • grid setup replaces the overwrite warning with a plain notice of what it does. grid sync applies without it.

Before (on setup and on every sync that changed a value, including values Grid wrote itself):

warning: existing integration settings in claude, opencode will be overwritten; teardown does not restore them

After (on setup, whenever it changes settings):

Modifies harness settings to set Grid as the gateway with your configured models.
To remove Grid, run baseten grid teardown.
┃ Set up Grid?
  • The confirmation asks Set up Grid? on setup and Update harness settings? on sync, instead of Apply these harness changes?. The default output lists no changes, so "these" pointed at nothing.

  • In the --dry-run / --verbose summary, the sentence Existing integration settings will be overwritten; teardown does not restore them. becomes a row listing the settings whose values change, e.g. Replaces model, modelPicker.options.

💻 How

The notice shows whenever any plan changes settings, so it no longer depends on telling Baseten's earlier settings from the user's. The JSON replaced_settings field is unchanged.

🔬 Testing

Test_Grid_Setup_ReplacesSettingsAndPicker checks the notice and the Set up Grid? prompt on setup, the dry-run row, and that a sync which rewrites a hand-edited setting asks Update harness settings? and prints no notice. go test ./... passes except Test_Grid_Setup_RealHarness and Test_Grid_ClaudeServedModel_RealClaudeCode, which fail the same way on main on my machine. Not checked by hand in a terminal.

🤖 Generated with Claude Code

@sanieldalib sanieldalib changed the title Only flag settings of the user's that grid setup replaces, in plainer words Replace grid setup's overwrite warning with a plain notice Nov 13, 2026
@sanieldalib sanieldalib changed the title Replace grid setup's overwrite warning with a plain notice Replace grid setup's overwrite warning with a plain notice and clearer prompts Nov 13, 2026
@sanieldalib
sanieldalib marked this pull request as ready for review November 13, 2026 17:18
Copilot AI balanced review requested due to automatic review settings November 13, 2026 17:18
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T17:19:18.811141Z a569b4a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the harness-configuration messaging update.

No open issues 🎉

What changed in this PR

This PR clarifies Grid’s harness-configuration messaging: setup explains what it changes, while routine sync no longer displays an overwrite warning.

Changes:

  • Replace the setup warning with a plain notice and teardown instructions.
  • Use distinct setup and sync confirmation prompts, and list replaced settings in dry-run and verbose summaries.
  • Update tests to check the notice, prompts, replacement summary, and silent sync behavior.
File Description
internal/​cmd/​command.grid.go Updates setup and sync messaging, confirmation prompts, and replacement summaries.
internal/​cmd/​command.grid_test.go Checks the revised output and sync behavior after a manual settings edit.

Review effort: Balanced

sanieldalib and others added 4 commits November 13, 2026 12:55
…r words

Setup warned that existing settings would be overwritten whenever a
setting it manages changed value, including values an earlier setup
wrote. Every sync and rerun warned, and Codex's catalog file, which
Grid owns outright, did on almost every route change. Settings each
harness's teardown already claims as Baseten's no longer count.

The warning becomes a plain notice naming the harnesses, with a hint
to preview with --dry-run or remove Grid with teardown, and the dry-run
summary lists the settings it replaces.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The notice now describes what setup does instead of warning about the
user's settings, so it is accurate on every setup and doesn't need to
tell Baseten's own settings from the user's. Sync applies without it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…pply these harness changes?"

The default output lists no changes, so "these" pointed at nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sanieldalib
sanieldalib force-pushed the salib/grid-overwrite-warning branch from a569b4a to 1d016de Compare November 13, 2026 20:57
@sanieldalib
sanieldalib merged commit f82e923 into main Nov 13, 2026
8 of 10 checks passed
@sanieldalib
sanieldalib deleted the salib/grid-overwrite-warning branch November 13, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants