Repository navigation
Show per-setting changes in grid setup's verbose summary - #264
Open
sanieldalib wants to merge 3 commits into
Open
sanieldalib wants to merge 3 commits into
sanieldalib wants to merge 3 commits into
Conversation
sanieldalib
force-pushed
the
salib/grid-verbose-summary
branch
from
November 13, 2026 20:57
4f49da6 to
a9ca1db
Compare
The verbose and dry-run summary interleaved raw "Config:/Settings:" log lines with the per-harness rows, so long setting lists wrapped across the terminal unaligned. Each harness now lists the files it changes, with "Replaces" and "Sets" rows wrapped to the terminal width. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Plans now record which settings they add, update or remove, and the summary lists those per file, without values, instead of every key Grid manages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
--dry-run now reads "Show the changes without applying them", the output descriptions say what --dry-run and --verbose list, and the long help uses the same wording as setup's notice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sanieldalib
force-pushed
the
salib/grid-verbose-summary
branch
from
November 13, 2026 22:20
a9ca1db to
299b8df
Compare
sanieldalib
marked this pull request as ready for review
November 13, 2026 22:33
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The dry-run confirmation preview incorrectly labels whole-file deletions as rewrites, obscuring which files will be removed.
1 open issue
What changed in this PR
This PR makes Grid setup and sync previews easier to read by replacing raw settings logs with per-file change summaries, building on the clearer setup notice from #262.
Changes:
- Track added, updated, and removed settings without exposing values, plus changes to owned files.
- Display sorted, colored changes per file in verbose and dry-run summaries, omitting unchanged settings.
- Update help text and assertions for the new preview format while preserving JSON output.
| File | Description |
|---|---|
| internal/harness/harness.go | Track setting and owned-file changes in plans. |
| internal/harness/claude_code.go | Include teardown hook changes in plan tracking. |
| internal/cmd/command.grid.go | Render per-file changes in verbose summaries. |
| internal/cmd/command.grid_test.go | Assert add/update rows and omission of untouched settings. |
| cmd/command.grid.go | Clarify setup, sync, and dry-run help text. |
Review effort: Balanced
Comment on lines
+1350
to
+1351
| if len(p.Changes) == 0 { | ||
| ctx.Outputf("\n Rewrites %s\n", gridHarnessDisplayPath(p.Path)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

grid setup --verbose/--dry-runprinted rawConfig: … / Settings: …log lines between the per-harness rows. They listed every key Grid manages, whether or not it changes, used absolute paths, and wrapped across the whole terminal. The singleReplacesrow merged keys from all of a harness's files.Plans now record a
Changeslist (add / update / remove per setting, no values), computed inPlan.encodeso it stays right after credentials are staged. Owned-file plans (Codex catalog, OpenCode plugin files) report per file. The summary lists the changes per file, coloured, and skips settings that don't change.After (
grid setup --dry-run, trimmed):Help text for setup and sync:
--dry-runreads "Show the changes without applying them or creating an API key."--dry-runlists each setting to add, update or remove and stops, and--verboselists the same changes before asking to apply.--dry-runshows each change first.JSON output is unchanged.
Test_Grid_Setup_ReplacesSettingsAndPickerasserts update/add rows and that untouched settings aren't listed.Test_Grid_Setup_RealHarnessandTest_Grid_ClaudeServedModel_RealClaudeCodefail locally the same way they do on main.🤖 Generated with Claude Code