Repository navigation
Conversation
Centralize empty-map formula removal in SheetData and skip spill metadata probes when no spill exists. Nine alternating comparison rounds improve one-million-row mixed-column ingestion by 35.2%; five better-warmed rounds keep the centralized helper within 2.67% of the original optimization, with identical output and 718 bytes of justified default wasm growth.
chh-ay
added this pull request to stack #69
October 6, 2026 08:45
This was referenced Oct 6, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Faster bulk writes in both engines. Part of #59. Stacked on #73 (base
perf/core-gaps).Problem
Profiles of 1,000,000-row ingestion showed every written cell paying hash probes into the sheet's formula and spill maps, even when a sheet has no formulas and no spills, which is the usual case for loaded data.
Change
SheetData::remove_formularemoves a cell's formula and skips the hash when the sheet has none. Every write path instore.rsuses it.prepare_cell_writereturns at once when the sheet has no spill metadata.setBlockPackedskips per-cell source lookups for blocks that carry no formula sources.Measurement
Both locks held, one pinned CPU, each side loading its own built package; outputs identical.
A/A control: 9 rounds, paired noise within ±3.4%. ABBA: 9 rounds. Centralizing the guard in one helper was checked against the first version: +2.7% (within ±3%).
Size
Verification
--features analysis) pass; library clippy passes in both configurations.docs:check,api:check, typecheck, lint pass; packages 869 pass / 6 skip / 0 fail.