Repository navigation
fix(licensing): keep popili off remote executors under the local licence modes - #256
Open
GPLeemrijse wants to merge 1 commit into
Open
GPLeemrijse wants to merge 1 commit into
GPLeemrijse wants to merge 1 commit into
Conversation
GPLeemrijse
force-pushed
the
fix/local-license-no-remote-exec
branch
from
November 5, 2026 17:43
f828894 to
3ff3169
Compare
GPLeemrijse
marked this pull request as ready for review
November 5, 2026 17:52
GPLeemrijse
marked this pull request as draft
November 5, 2026 21:05
GPLeemrijse
force-pushed
the
fix/local-license-no-remote-exec
branch
2 times, most recently
from
November 6, 2026 16:22
c4ca276 to
4a435e0
Compare
GPLeemrijse
marked this pull request as ready for review
November 6, 2026 16:51
GPLeemrijse
force-pushed
the
fix/local-license-no-remote-exec
branch
from
November 6, 2026 17:10
4a435e0 to
e2875ff
Compare
…nce modes local_user and local_acquire read a licence on this machine, but nothing stopped popili's actions and tests from running remotely. Both modes now tag them no-remote-exec; results stay cacheable. They also get this machine's popili: the hub enables other execution platforms' toolchains only under the licence modes that let popili run remotely.
GPLeemrijse
force-pushed
the
fix/local-license-no-remote-exec
branch
from
November 6, 2026 17:20
e2875ff to
d4b9b7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under
local_userandlocal_acquirepopili reads a licence on this machine, but nothing stopped its actions and tests from running remotely, or from getting the popili of another execution platform listed first. Both modes now tag generate, typecheck,popili_ruleactions and popili-running testsno-remote-exec(results stay cacheable), and the toolchain hub enables other execution platforms' toolchains only under the licence modes that let popili run remotely, so the local modes always get this machine's popili. When that leaves no toolchain, the error says why.license_sourceis now also checked against the known modes incoco.toolchain,coco_toolchainandcoco_repositories.Here the licence file stays an action input, so it is part of the action key: under
local_userevery licence renewal by popili's daemon reruns every popili action and test. #258, stacked on this PR, fixes that by passing thelocal_userlicence by absolute path instead, which is only sound because popili no longer runs remotely in that mode; #264 does the same forlocal_acquire.