Repository navigation
feat(rules): local_user now uses paths as input instead of files to improve caching - #258
Open
GPLeemrijse wants to merge 1 commit into
Open
GPLeemrijse wants to merge 1 commit into
GPLeemrijse wants to merge 1 commit into
Conversation
GPLeemrijse
force-pushed
the
fix/local-user-licence-path
branch
from
November 5, 2026 17:46
4b56aed to
03bd368
Compare
GPLeemrijse
marked this pull request as ready for review
November 5, 2026 17:53
GPLeemrijse
marked this pull request as draft
November 5, 2026 21:05
GPLeemrijse
force-pushed
the
fix/local-user-licence-path
branch
2 times, most recently
from
November 6, 2026 16:22
591c3ad to
968de4f
Compare
GPLeemrijse
marked this pull request as ready for review
November 6, 2026 16:51
GPLeemrijse
force-pushed
the
fix/local-user-licence-path
branch
from
November 6, 2026 17:10
968de4f to
eba40d7
Compare
… improve caching
GPLeemrijse
force-pushed
the
fix/local-user-licence-path
branch
from
November 6, 2026 17:20
eba40d7 to
c2de1e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under
local_user, popili now gets the licence file by its absolute path instead of as an action input. popili's licensing daemon rewrites that file as it renews, and that used to rerun every popili action and test. The newlicense_pathsrule replaces the symlinked filegroup, and wrapper scripts quote popili's startup arguments literally, so a path with spaces or shell characters (such as macOS'sApplication Support) reaches popili unchanged. Passing the licence by path is only sound because #256 keeps popili off remote executors, so this PR is stacked on #256. It also relies on the sandbox exposing popili's data directory read-only, which Bazel's default sandboxes do.