Repository navigation
feat(rules)!: replace coco_generate's mocks with coco_package's cpp_mocks and csharp_mocks - #257
Open
GPLeemrijse wants to merge 1 commit into
Open
GPLeemrijse wants to merge 1 commit into
GPLeemrijse wants to merge 1 commit into
Conversation
GPLeemrijse
force-pushed
the
fix/generate-mocks
branch
from
November 6, 2026 17:15
b9b0a7c to
d720391
Compare
GPLeemrijse
changed the title
GPLeemrijse
force-pushed
the
fix/generate-mocks
branch
from
November 6, 2026 17:39
d720391 to
3f4d439
Compare
…ocks and csharp_mocks The attributes mirror generator.cpp.generateMocks and generator.csharp.generateMocks and only declare the mock outputs; passing popili's --mocks is not possible while --mocks=none suppresses the regular generated code.
GPLeemrijse
force-pushed
the
fix/generate-mocks
branch
from
November 6, 2026 18:23
3f4d439 to
0380122
Compare
GPLeemrijse
marked this pull request as ready for review
November 6, 2026 18:26
tomgr
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mocks = Truenever reached popili, so it only worked whengenerateMockswas also set inCoco.toml, and nothing documented that. It is replaced by thecoco_packageattributescpp_mocksandcsharp_mocks, which mirrorgenerator.cpp.generateMocks/generator.csharp.generateMockslike the other generator attributes (#269) and declare the*Mock.*outputs. The README table now lists them. Passing popili's--mocksis not possible:--mocks=nonemakes popili write only the mocks and none of the regular code. We therefore never pass the flag and all this attribute does is declare the outputs. C has no mocks setting, sotest/c_mocks_unsupportedis gone.Breaking: replace
mocks = Trueon thecoco_generatewithcpp_mocks = "GMock"(or"GMockNumberMacros") on itscoco_package, matchingCoco.toml; for a C#coco_generate, withcsharp_mocks = "NSubstitute".