Repository navigation
feat(rules)!: move coco_generate's Coco.toml generator attributes to coco_package - #269
Open
GPLeemrijse wants to merge 1 commit into
Open
GPLeemrijse wants to merge 1 commit into
GPLeemrijse wants to merge 1 commit into
Conversation
…coco_package The c_*, cpp_* and csharp_* attributes mirroring [generator.<language>] in Coco.toml now live on coco_package and reach coco_generate through CocoPackageInfo.generators, so every coco_generate of a package agrees on them. include_prefix is split into cpp_include_prefix and c_include_prefix. coco_generate keeps only package, language, mocks and popili_version. Regenerated packages must be among the package's deps, as popili regenerates only dependencies.
GPLeemrijse
force-pushed
the
feat/package-attributes
branch
from
November 6, 2026 18:23
cff71c6 to
979cf7f
Compare
GPLeemrijse
marked this pull request as ready for review
November 6, 2026 18:25
tomgr
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
c_*,cpp_*andcsharp_*attributes that mirror[generator.<language>]inCoco.tomlmove fromcoco_generatetococo_package, which passes them to everycoco_generateof the package throughCocoPackageInfo.generators. They describe the package'sCoco.toml, so all of its generates now agree on them.include_prefixis split intocpp_include_prefixandc_include_prefix.coco_generatekeepspackage,language,popili_versionand, until #257,mocks. A package in*_regenerate_packagesmust be among the package's (transitive)deps, as popili regenerates only dependencies; this is checked at analysis.Breaking: move these attributes from your
coco_generatetargets to theircoco_package;include_prefixbecomescpp_include_prefix/c_include_prefix.