build: support Rust 1.80 - #333
Merged
Merged
Conversation
Lower the declared MSRV for the runtime, generators, and examples. Resolve compatible dependencies with a newer Cargo before running the Rust 1.80 CI checks. Signed-off-by: Tim Zhang <tim@hyper.sh>
Tim-Zhang
force-pushed
the
fix/msrv-1.80
branch
from
September 23, 2026 09:10
c036aa0 to
7ee00f6
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Rust 1.81-only APIs, unconstrained downstream dependencies, and incomplete example coverage invalidate the Rust 1.80 claim.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Lowers the declared MSRV to Rust 1.80 and updates CI compatibility testing.
Changes:
- Updates MSRV metadata and documentation.
- Adds Rust 1.80 dependency resolution and CI testing.
- Updates runtime, generators, and examples.
| File | Review |
|---|---|
ttrpc-codegen-prost/Cargo.toml |
Declares Rust 1.80, but uses std::io::Error::other, which requires Rust 1.81. |
README.md |
Documents Rust 1.80 compatibility. |
example/Cargo.toml |
Declares Rust 1.80 compatibility, but CI does not compile its example targets. |
example-prost/Cargo.toml |
Declares Rust 1.80 compatibility. |
Cargo.toml |
Lowers the workspace MSRV despite Rust 1.81-only Error::other usage. |
.github/workflows/bvt.yml |
Adds MSRV testing, but generated lockfiles do not constrain downstream resolution and the regular examples are not explicitly checked. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Constrain transitive dependencies that otherwise select releases requiring newer Cargo. Resolve and test from a clean checkout with only the Rust 1.80 toolchain. Signed-off-by: Tim Zhang <tim@hyper.sh>
Tim-Zhang
force-pushed
the
fix/msrv-1.80
branch
from
September 23, 2026 11:31
6cc4d83 to
8f3ffcc
Compare
Keep Rust 1.80 CI on compatible tempfile and indexmap releases without imposing those upper bounds on downstream users. Document consumer-side constraints and check fresh consumers. Signed-off-by: Tim Zhang <tim@hyper.sh>
Drop the separate consumer fixture from the MSRV job. The crate checks cover our supported code; downstream users control transitive dependency resolution in their own projects. Signed-off-by: Tim Zhang <tim@hyper.sh>
Describe the different indexmap limits for Rust 1.80–1.81 and 1.82–1.84. Keep the guidance in the root README only. Signed-off-by: Tim Zhang <tim@hyper.sh>
wllenyj
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust 1.85 unnecessarily restricts downstream users. Lower the runtime, generators, and examples to Rust 1.80.
Keep
tempfileandindexmapcompatibility bounds in development dependencies for MSRV checks, so ttrpc does not impose them on downstream projects. Document the compatible transitive dependency ranges for Rust 1.80–1.84 users in the root README.