Repository navigation
Conversation
Keep captured catalog roots in the shared file lookup instead of copying all file bindings. Mount capture uses the paged Git view so checkpoint bodies stay cold. Preserve close ownership and authenticate the selected dependency closure.
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remote snapshot hydration and mount setup materialized every file binding in the captured Xet catalog before requesting a file. Pass captured authenticated lookup roots through
SharedFileIndexLookupinstead. Point/batch queries fetch the selected file, shard and xorb closure with the existing page cache and query budget, preserving file precedence and descriptor conflicts.Mount setup also switches to the existing paged Git-view capture; retaining its previous complete-checkpoint opener would leave an eager read before lookup. Shared-reader initialization, active-read guards and exclusive close ownership remain unchanged. Missing pages are errors and never reopen mutable metadata.
Evidence map
crab/src/read/mod.rs::remote_snapshot_git_dirandcrab/src/cmd/mount.rs::resolve_mount_read_context_from_remote_url.SharedFileIndexLookupretains the capturedPointerCatalogLookup;lookup_batchcalls its authenticated selected-closure reader. Hydration continues through the canonicalShardHydratorand whole-file hash checks.FileIndexLookupSession::open_with_moderemains eager; shard-index sessions retain their existing behavior. Shared receive conversion is tracked separately in perf(remote): select publication catalog dependencies #579. Complete maintenance inspection remains intentional.Is this the best fix? Reusing metadata's captured page reader and shared session owner removes eager pinned catalog maps without a second selection or reconstruction policy. The remaining current-state opener needs a shared capture-owner extraction rather than another independent ref-ordering implementation.
Validation
Passed: all 29 metadata file-lookup regression tests, including the new page-bound and corruption cases. Passed: pinned reconstruction through the paged catalog with real shard/xorb descriptors and no pointer shard hint. The first fixture compile failed with E0283; the explicit
MerkleHashconversion fixes type inference without changing assertions. Passed on43203ff48f6: CLI library/binary check withsimd-accel,gix-pathmatch,nfsand no default features (7m13s; 12 minimal-profile warnings, not a strict-lint pass). Pending: source-bound runtime and retained-capture lifecycle proof. Draft only until evidence is complete. No benchmark audit reports or architecture/expected-failure baselines are modified.