Repository navigation
Conversation
Share captured ref ordering and visibility with Git readers. Validate full catalog dependencies after assembling the visible cross-ref set.
Preserve read-side corruption classification when shared metadata code detects conflicting captured controls. Keep transport errors as metadata sources.
Measure opening before cold and warm selected queries. Compare duplicate results with full inspection only after closing the session.
Prove cold catalog pages survive checkpoint replacement and a real orphan sweep. Repair the async visibility test caller and carry forward the qualified staging-version fixture. Record the remaining shallow-date adapter failure without weakening its CLI smoke assertion.
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current-state file lookup reconstructs the complete historical pointer catalog before answering a selected file query. This change captures authenticated checkpoint/run controls once and uses the existing paged catalog lookup for requested file bindings and their dependency closure.
Stacked on #582. The combined indexed-read/shared-staging work is in #578; this PR is the next bounded catalog-reader slice. No storage format, dependency, or configuration changes.
Changes
PointerCatalogLookup; preserve batch order, duplicate requests, missing-file results, session closure, and fail-closed v2 authority.crab-metadata, so Git and catalog readers share authentication and publication ordering rules. Remove the superseded read-side implementation and full catalog scan.PointerCatalog::applyremains strict.Validation
cargo fmt --all --checkandgit diff --check: passed.file-index-reader,-D warnings) passed. CLI/NFS library/binary compilation and the debug CLI build passed (minimal-profile warnings remain; not a strict CLI lint claim).qualify_remote ... <catalog-file-hash> catalog-currentoperation builds and passes against the four-version, two-file 10 GiB RustFS dataset. Opening: 28 operations / 149,860 bytes. Cold and warm duplicate-file queries each use 497 ranges / 7,434,846 bytes; results match full inspection, with zero writes and drained operations. The repeated warm recipe reads are a measured remaining performance gap.MerkleHash::hex(). Correcting that external input made the unchanged binary pass. This is one local debug-profile functional sample, not cloud latency or independent history-scaling proof.Evidence map and review question
FileIndexLookupSession::open_with_modeincrates/crab-metadata/src/file_index_lookup.rsload_pointer_catalog_lookup_from_rootincapsule_protocol/catalog_capture.rs; existing authenticated checkpoint/run page readersref_view.rsandcaptured_visibility.rs; both full materializers usePointerCatalogAssemblyfile_index_lookup/catalog_tests.rs,capsule_protocol/store/tests.rs, pointer assembly tests, retained read visibility opening testIs this the best fix? Sharing metadata capture avoids separate Git/catalog publication policies, and one opaque assembly boundary fixes cross-ref inspection without weakening strict publication validation. Review the new public storage API surface and the remaining lifecycle qualification before marking ready.
The net source growth supplies current-state capture plus cross-ref assembly; moved ordering/visibility replaces duplicate implementations. The two requested
large-file-push-auditbenchmark reports are excluded.The lifecycle qualification and pending CLI-smoke failure are recorded in
8c7d20ea393. The separate bounded verified-binding optimization addresses the measured repeated warm recipe reads; its parent API and cold dependency proof remain the ones established here.