Repository navigation
Conversation
dayfine
force-pushed
the
bbq/reroll-impossible-quests
branch
from
October 23, 2026 04:25
43bb0a6 to
26914e9
Compare
dayfine
force-pushed
the
bbq/unsupported-quest-rerolls
branch
from
October 27, 2026 06:52
5fc1be4 to
5752997
Compare
dayfine
force-pushed
the
bbq/reroll-impossible-quests
branch
from
October 27, 2026 06:52
26914e9 to
17e3a94
Compare
dayfine
changed the base branch from
bbq/unsupported-quest-rerolls
to
bbq/exhausted-quest-actions
October 27, 2026 06:53
dayfine
force-pushed
the
bbq/exhausted-quest-actions
branch
from
October 27, 2026 19:16
7f8931a to
41b3e4f
Compare
dayfine
force-pushed
the
bbq/reroll-impossible-quests
branch
from
October 27, 2026 19:16
17e3a94 to
8ee9306
Compare
This was referenced Oct 27, 2026
dayfine
force-pushed
the
bbq/exhausted-quest-actions
branch
from
October 28, 2026 03:43
41b3e4f to
c0dfb0b
Compare
dayfine
force-pushed
the
bbq/reroll-impossible-quests
branch
from
October 28, 2026 03:43
8ee9306 to
74a0749
Compare
plan_quests() dropped quests the farmer cannot do (pickup, flying photo and catch) before looking at the exclusions table, so a reroll row for one of them did nothing: the quest stayed on the panel and blocked the slot. Pickup could not be picked in the table at all. The table is now applied first. Reroll and skip rows work for quests the farmer cannot do; a run row for one is ignored, since there is no route for it. Pickup is listed in the table. With nothing to do and nothing rerolled, the first quest the farmer cannot do that has no table row is rerolled instead of every quest, which costs one reroll instead of three or four. Every quest is still rerolled when there is no such quest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
plan_quests() left a quest it cannot do (pickup, photo flying, catch flying) on the panel unless the exclusions table had a row for it, and rerolled one only when nothing else was doable. A red photo-flying and a blue catch-flying then held 2 of 4 slots for over 20 minutes, and no new red quest could appear. Reroll each such quest when it is read: 10 BP for a blue, 50 BP for a red, which pays 100-150 BP and blocks the next red while it stays. A table row for the quest still decides instead. With every one of them rerolled, the one-slot fallback has nothing left to pick, so it is removed; reroll-all still covers a panel with nothing doable and nothing rerolled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Rerolling a quest not possible on sight (C15) spent BP the player might not have: out of BP the reroll did not happen, and the program stopped with "Check that there is enough BP" before the doable quests ran. plan_quests() now takes the BP balance. While other quests are doable, a quest not possible is rerolled only if the BP left after the other planned rerolls covers it (red 50, blue 10); otherwise it is skipped as before C15 and the doable quests run. Unknown BP skips it too. With nothing doable, every quest not possible is still rerolled. process_quest_list() reads BP (one more panel open) only when the board has a quest not possible. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/exhausted-quest-actions
branch
from
October 28, 2026 08:14
c0dfb0b to
01e5059
Compare
dayfine
force-pushed
the
bbq/reroll-impossible-quests
branch
from
October 28, 2026 08:14
74a0749 to
a45c9de
Compare
…uests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…uests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…uests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Owner
Author
|
Superseded by consolidated Tree 1 PR #272. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PokemonAutomation/ComputerControl#263.
Behavior change: the farmer rerolls more.
Problem
In live run R5a, a red "photo a Flying-type" quest and a blue "catch a Flying-type" quest held 2 of the 4 panel slots for over 20 minutes. The farmer can't do either (both are in
not_possible_quests, with pickup).plan_quests()only skipped such a quest unless the exclusions table had a row for it, and rerolled one only when nothing else on the panel was doable. Then it picked the first one, which is the red quest when there is one (slot 0).A red quest pays 100-150 BP, and the next red can't appear while one sits in slot 0. So the stuck red quest cost far more than its 50 BP reroll.
Change
plan_quests()rerolls a quest the farmer can't do as soon as it reads it, if the exclusions table has no row for it:A table row still wins. A skip row keeps the quest on the panel. A run row is still ignored, so the quest is neither run nor rerolled. The exclusions table already let a user do this per quest with a reroll row (#9); this makes it the default for quests that have no row.
The one-slot fallback is gone. With every such quest rerolled, nothing is left for it to pick, so there's no "cheapest slot" choice to make. Reroll-all is unchanged: it runs when nothing is doable and nothing was rerolled, e.g. when every quest the farmer can't do has a skip row.
An undetected quest (
UnableToDetect) is still neither run nor rerolled.Only when BP covers it (second commit, 43bb0a6). While other quests are doable, a quest the farmer can't do is rerolled only if the BP left after the other planned rerolls (table rows, out-of-egg hatch) covers its cost; otherwise it is skipped, as before this PR, and the doable quests run.
process_quest_list()reads BP withread_BP()(one more panel open) only when the board has such a quest; an unreadable BP skips it too. With nothing doable, every such quest is still rerolled whatever the BP, as in the first commit. Without this, a low-BP player stopped with "Check that there is enough BP" before running the doable quests. Note:read_BP()on this branch still has the crop that PokemonAutomation#1628 fixes (6750 read as 67501), so until that merges a low balance can read high.Rerolls still go through #8's
reroll_quest(), which checks the quest was replaced. If it wasn't (most likely out of BP), the program stops as before. The endless-reroll guard (#5) isn't in this branch, and this change doesn't touch it.Tests
PokemonSV::BBQuestPlan, 7 new cases:2 cases updated for the new behavior: "a quest not possible is rerolled, an undetected one is not" (was "quests not possible are left out") and "a rerolled slot with nothing doable does not reroll all" (pickup is now rerolled too).
Second commit, 6 more
BBQuestPlancases (each scenario now has abp, default 1000):All 35 native BBQ cases pass: 26
BBQuestPlan, 9BBQReroll(macOS arm64).Lab merge note: fork #22's
SimulatedBBQGameActionscomment says itsprocess_quest_list()skips quests innot_possible_quests. That's a model of the round loop, not a test ofplan_quests(), so it still passes. Its comment describes the old rule.Tested on the Switch with the rest of stage 1 in runs S1b and S1c (STAGE_RUNS.md): 15 quests, no stretch over 11 min without a completion, BP check OK. With the flying rows removed from the exclusions table, 3 quests not possible were rerolled as soon as they appeared.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This PR now also carries the exclusions-table commit from the closed #9, which it builds on.