Repository navigation
BDSP AutoStory: routes stop short of warps; a dim cave floor is not a tap's fade - #269
Merged
dayfine merged 4 commits intoNov 9, 2026
Merged
Conversation
01.05's open walk west to (2, 13), beside the Oreburgh Gate's mouth, slid onto the warp (lab-B 2026-11-08, four runs). A table test plans every ROUTE step as the walker does and fails on an open leg that may end on the tile before a door it walks toward. It flagged 01.05's old by_the_gate and four more: 00.03 above_the_door_again (now counted legs from the west), 01.02 by_the_east_mouth and 01.05 through_the_gate (two tiles short of the Gate's mouths, the taps go the rest), and 01.03 above_the_mine (two rows above the warp row, the door run goes on). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Moved unchanged out of StorySim_Tests.cpp, which is at the 1000-line limit: r75's and r81's old cave exits and the old mine steps. The next commit adds 01.05's old tap into the Oreburgh Gate beside them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
On lab-B (2026-11-08 15:31 to 15:54) 01.05's walk slid into the Oreburgh Gate, and its tap step read the Gate's floor (about 46) as the fade and waited 8 s for a banner already gone. A look after a tap is the fade only when black (< 25) or a drop to dark from the look before the tap (tap_faded()). A banner before the first tap means the walk before took us through: the step ends with no tap. A tap step taps at most two past the door its map has ahead, so one begun through the warp with its banner gone fails a few tiles in, not across the Gate. Tests: tap_faded() on the Gate's floor and real fades; the story sim's 01.05 tap step begun through the Gate's mouth, banner up and gone (red before: 24 taps across the Gate); GridSim's part-tile offset taking the warp on the old open walk west. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…s stopgaps Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
marked this pull request as ready for review
November 9, 2026 00:45
dayfine
merged commit Nov 9, 2026
013c4bd
into
bdsp/autostory-mine-floaroma-wip
16 of 23 checks passed
dayfine
added a commit
that referenced
this pull request
Nov 9, 2026
…warps #269 moved the route's target to (46, 57); the authored plan follows it in the merge, and its doc now says so too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
that referenced
this pull request
Nov 9, 2026
… line (#264) * Make existing BDSP recovery tests compile across GCC and Clang-cl * BDSP: load mine/Roark checkpoint from shared authored JSON (#263) * Load BDSP mine checkpoint from shared JSON without changing its executor * Pin the BDSP replay schema correction for paired CI * Compare normalized checkpoint semantics instead of optional JSON defaults * Share authored checkpoint envelopes and embedded resource loading * Use shared authored checkpoint loading for BDSP * Make the native mine plan authoritative and address data review * Space BDSP data declarations and test mutation helpers * Resolve simulator staging root across Python versions * Keep existing Git normalization rules for authored story data * Report actual BDSP story data values in test failures * BDSP AutoStory: the mine doc's above_the_mine stops two short of the warps #269 moved the route's target to (46, 57); the authored plan follows it in the merge, and its doc now says so too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
bdsp/autostory-mine-floaroma-wip(#226); the diff shows only this change. Sibling of #262, which moves the same sim code; expect a small conflict inStorySim_Tests.cppwhen both land.On lab-B (2026-11-08, four runs) 01.05's open walk to the tile beside the Oreburgh Gate's mouth slid onto the warp, and the tap step after it read the Gate's dim floor as its fade and waited for a banner already gone. This fixes both halves in shared code rather than in that one row.
by_the_gateand four more, now fixed: 00.03above_the_door_again(counted legs from the west), 01.02by_the_east_mouthand 01.05through_the_gate(two tiles short of the Gate's mouths; the taps go the rest), 01.03above_the_mine(two rows above the warp row; the door run goes on). 01.02'sby_the_gatewas not flagged. I kept this in the table, not the planner: when the target is itself beside a warp (row 58 above the mine is all beside warps), the planner can't fix it.tap_faded(): a look after a tap counts as the fade only when it is black (< 25), or when it drops to dark from the look before the tap. A banner showing before the first tap ends the step with no tap ("through already"). A tap step now stops two taps past the door its map has ahead, so a step that starts inside the Gate with its banner gone fails a few tiles in instead of walking across the Gate.TODO(#268 ...)inStoryStepIO.cpp: the brightness-drop fade test intap_faded()(slice 3, a uniform-screen fade watcher) and the "through already" banner check intap_to_banner()(slice 2, walkers report the warp they saw). Remove each once its replacement passes the same tests.Simulation/PokemonBDSP_AutoStory_OldStorySteps.*(StorySim_Tests.cpp was at the 1000-line limit); review commit by commit,git diff --color-moved=dimmed-zebra c19b41111^ c19b41111.Testing
by_the_gate) and on 95b2960 (4 legs), and passes now.tap_fadedfailed on the Gate's floor (46 → 46) under the old rule. The two story-sim cases for a tap step that starts through the Gate's mouth (banner up, banner gone) failed with the old walker: it took 24 taps across the Gate. All of these pass now.SerialProgramsTests --filter PokemonBDSP::AutoStory: 103 passed. 2 failed, and both fail on the base too: Grid sim "01.03 oreburgh_north…" and "01.03 above_the_mine… across seeds" (Unknown exception). Nothing ran on the console.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss