Skip to content

BBQ Farmer: make the Auto Battle pass log add up to the kill total (behavior change) - #31

Closed
dayfine wants to merge 6 commits into
bbq/auto-battle-heal-thresholdfrom
bbq/auto-battle-kill-count
Closed

dayfine wants to merge 6 commits into
bbq/auto-battle-heal-thresholdfrom
bbq/auto-battle-kill-count

Conversation

@dayfine

@dayfine dayfine commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Depends on #21 (heal threshold) → #18 → #17 → #15 → #51 (PokemonAutomation#1754). Base: bbq/auto-battle-heal-threshold; the diff shows only this change.

Part of PokemonAutomation/ComputerControl#263.

The kill sound is heard in every step, so a kill the lead finished as the flight back started went into the total but into no pass (R3b: "pass 2: 1 kills, 4/10 in total" right after "2/10"). Each pass now counts the kills since the previous pass's line, so the passes add up to the total and such a kill keeps the next pass from counting as empty. Behavior change: if kills heard on the way back reach the target, the attempt stops without healing instead of healing first. The fake can now hear kills on the way back, and three new PokemonSV::BBQAutoBattle scenarios cover the R3b sequence, the empty-pass reset and the stop; the native BBQ runner passes 29 of 29.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

The kill sound is heard in every step, not only while clearing: the lead
can finish a kill after the clear ends, as the flight back starts. Each
pass counted kills from its own start, so such a kill went into the total
but into no pass ("pass 2: 1 kills, 4/10" after "2/10" in R3b). Each pass
now counts the kills since the previous pass's line, so the passes add up
to the total.

Behavior change: when kills heard on the way back reach the target, stop
without healing instead of healing and then stopping.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine dayfine added farmer Farming programs game:sv Scarlet/Violet labels Nov 1, 2026
@dayfine

dayfine commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

Superseded by consolidated Tree 2 PR #273.

@dayfine dayfine closed this Nov 9, 2026
@dayfine
dayfine deleted the bbq/auto-battle-kill-count branch November 13, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

farmer Farming programs game:sv Scarlet/Violet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant