Repository navigation
Conversation
This was referenced Oct 22, 2026
PokemonSV_Tests.cpp registers every SV test, and each BBQ change adds its controller tests there, so parallel BBQ changes all conflict in it. Move the Tera encounter tests unchanged into Programs/Farming/PokemonSV_BBQTests.cpp, registered through one add_tests_BBQ() call, following the add_tests_<Module>() pattern the detectors use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Move the decisions of quest_auto_battle() into run_auto_battle(), with the game steps (fly to Chargestone, clear, return to Central Plaza, heal) behind BBQAutoBattleActions. The console version makes today's calls with today's buttons and timings, so behavior is unchanged. The interface is the one the follow-up policies need, so they change only the loop: clear() takes a kill count to stop at and returns the lead's last known HP, and run_auto_battle() returns why it stopped. For the stop count, use_lets_go_to_clear_in_front() takes an optional stop_early predicate; its default is none, so its other callers are unchanged. The loop passes no stop count yet, so every clear still runs until no kill has been heard for 6 seconds. Log one line per pass: its kills, the running total, the lead's HP, the time spent and what happens next. Native tests in PokemonSV_BBQTests.cpp use a scripted fake that charges each step the seconds measured on one live pass, and pin today's behavior: the final pass still heals, and with no kills the loop never ends. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/auto-battle-seam
branch
from
October 28, 2026 08:07
da1ffc8 to
0181f81
Compare
dayfine
force-pushed
the
bbq/tests-file
branch
2 times, most recently
from
October 28, 2026 20:37
bf82b48 to
daa1de3
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Owner
Author
|
Superseded by consolidated Tree 2 PR #273. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PokemonAutomation/ComputerControl#263.
An Auto Battle quest spends most of its time outside battle, and its loop can't be changed safely (stop at the target, bound the attempt, heal less) until its decisions run without a Switch. This moves the loop of
quest_auto_battle()intorun_auto_battle(), with the game steps behindBBQAutoBattleActions, and logs one line per pass (kills, total, the lead's HP, time, next step); the console implementation makes today's calls with today's buttons and timings, so behavior is unchanged. The interface is already the one the follow-ups need, so they change only the loop:clear(stop_at_kills)returns the lead's last known HP, backed by a new opt-instop_earlypredicate onuse_lets_go_to_clear_in_front()(default none, so its other callers are unchanged), andrun_auto_battle()returns aBBQAutoBattleResult; for now the loop never stops a clear early and only logs the HP.ConsoleBBQAutoBattleActionsholds the old loop body moved with renames (contexttom_context, etc.), so compare it by eye withgit diff --color-moved=dimmed-zebra --color-moved-ws=allow-indentation-change bbq/tests-file...bbq/auto-battle-seam. ThePokemonSV::BBQAutoBattletests inPokemonSV_BBQTests.cpppin today's behavior with a scripted fake timed from one live pass; with the full app built on macOS arm64, the native BBQ runner passes 15 of 15.🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E