Repository navigation
Conversation
This was referenced Oct 22, 2026
dayfine
force-pushed
the
bbq/auto-battle-stop-at-target
branch
from
October 23, 2026 04:19
f7800e9 to
caaf791
Compare
dayfine
force-pushed
the
bbq/auto-battle-bounds
branch
from
October 23, 2026 04:19
2f490c4 to
b2631b6
Compare
run_auto_battle() had no bound: if kills stopped registering (wrong lead, no spawns, no audio) it never returned, and the farmer's retry handling could not step in. It now stops after 3 passes in a row with no kill, or after the pass that ends past the time limit (35 minutes for Auto Battle 10, 60 for Auto Battle 30, about 3x the slowest attempts seen). It returns to Central Plaza without healing, logs which limit ended it, and leaves the outcome to the board check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/auto-battle-stop-at-target
branch
from
October 28, 2026 08:07
caaf791 to
fda42de
Compare
dayfine
force-pushed
the
bbq/auto-battle-bounds
branch
from
October 28, 2026 08:07
b2631b6 to
a536fda
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Owner
Author
|
Superseded by consolidated Tree 2 PR #273. |
dayfine
added a commit
that referenced
this pull request
Nov 15, 2026
This was referenced Nov 15, 2026
dayfine
added a commit
that referenced
this pull request
Nov 15, 2026
Brings the reviewed slice chain (#572-#582) into the long-lived branch. Where both sides add the same file, plza/autostory's later version is kept and the slices' review fixes are applied on top: StoryRangeOptions moves to Pokemon/AutoStory/Options with #572's review fixes, SV takes the slices' version, the shared Outcome and Pose functions move to their own .cpp files, and add_tests_AutoStory() also registers the slices' new suites (StoryBackend, CheckpointAttempts, ScreenMachine, PLZA AutoStoryDialogDetector). The slices' PLZA AutoStoryGame tests are left out: they are written against the slices' smaller game API (make_plza_story_game_without_console(), unverified autosaves), which this branch has not adopted; its AutoStoryEngine tests cover the same game. The nine AutoStoryScreenEvents frames missing from CommandLineTests #18 are skipped as pending a recapture.
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PokemonAutomation/ComputerControl#263.
Nothing bounded the Auto Battle loop: if kills stop registering (wrong lead, no spawns, no game audio),
quest_auto_battle()never returns and the farmer's retry handling can't step in.run_auto_battle()now gives up after 3 passes in a row with no kill, or after the pass that ends past a time limit (35 min for Auto Battle 10, 60 for Auto Battle 30, about 3x the slowest attempts seen), returns to Central Plaza without healing, logs which limit ended it and returnsNoKillsorTimeLimit; the board check still decides whether the quest was done (behavior change, only when an attempt stalls). The limits are constants to tune from the pass logs. In the tests the "never stops" scenario became "gives up after 3 passes with no kill", with new scenarios for a kill resetting the count, the time limit, and the target reached past the limit; the native BBQ runner passes 18 of 18.🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E