Skip to content

BBQ Farmer: give up Auto Battle after 3 empty passes or a time limit (behavior change) - #18

Closed
dayfine wants to merge 6 commits into
bbq/auto-battle-stop-at-targetfrom
bbq/auto-battle-bounds
Closed

dayfine wants to merge 6 commits into
bbq/auto-battle-stop-at-targetfrom
bbq/auto-battle-bounds

Conversation

@dayfine

@dayfine dayfine commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Depends on #17 (stop at target) → #15 (Auto Battle seam) → #51 (PokemonAutomation#1754). Base: bbq/auto-battle-stop-at-target; the diff shows only this change.

Part of PokemonAutomation/ComputerControl#263.

Nothing bounded the Auto Battle loop: if kills stop registering (wrong lead, no spawns, no game audio), quest_auto_battle() never returns and the farmer's retry handling can't step in. run_auto_battle() now gives up after 3 passes in a row with no kill, or after the pass that ends past a time limit (35 min for Auto Battle 10, 60 for Auto Battle 30, about 3x the slowest attempts seen), returns to Central Plaza without healing, logs which limit ended it and returns NoKills or TimeLimit; the board check still decides whether the quest was done (behavior change, only when an attempt stalls). The limits are constants to tune from the pass logs. In the tests the "never stops" scenario became "gives up after 3 passes with no kill", with new scenarios for a kill resetting the count, the time limit, and the target reached past the limit; the native BBQ runner passes 18 of 18.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

run_auto_battle() had no bound: if kills stopped registering (wrong
lead, no spawns, no audio) it never returned, and the farmer's retry
handling could not step in. It now stops after 3 passes in a row with
no kill, or after the pass that ends past the time limit (35 minutes
for Auto Battle 10, 60 for Auto Battle 30, about 3x the slowest
attempts seen). It returns to Central Plaza without healing, logs which
limit ended it, and leaves the outcome to the board check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine
dayfine force-pushed the bbq/auto-battle-stop-at-target branch from caaf791 to fda42de Compare October 28, 2026 08:07
@dayfine
dayfine force-pushed the bbq/auto-battle-bounds branch from b2631b6 to a536fda Compare October 28, 2026 08:07
@dayfine dayfine added farmer Farming programs game:sv Scarlet/Violet labels Nov 1, 2026
@dayfine

dayfine commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

Superseded by consolidated Tree 2 PR #273.

@dayfine dayfine closed this Nov 9, 2026
@dayfine
dayfine deleted the bbq/auto-battle-bounds branch November 13, 2026 03:26
dayfine added a commit that referenced this pull request Nov 15, 2026
Brings the reviewed slice chain (#572-#582) into the long-lived branch.
Where both sides add the same file, plza/autostory's later version is kept
and the slices' review fixes are applied on top: StoryRangeOptions moves to
Pokemon/AutoStory/Options with #572's review fixes, SV takes the slices'
version, the shared Outcome and Pose functions move to their own .cpp files,
and add_tests_AutoStory() also registers the slices' new suites
(StoryBackend, CheckpointAttempts, ScreenMachine, PLZA AutoStoryDialogDetector).
The slices' PLZA AutoStoryGame tests are left out: they are written against
the slices' smaller game API (make_plza_story_game_without_console(),
unverified autosaves), which this branch has not adopted; its
AutoStoryEngine tests cover the same game.
The nine AutoStoryScreenEvents frames missing from CommandLineTests #18 are
skipped as pending a recapture.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

farmer Farming programs game:sv Scarlet/Violet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant