Repository navigation
Conversation
…T KEY as an authored plan From Celadon's Pokemon Center: the Game Corner's poster Grunt, the poster switch, the hideout down to B4F's Lift Key Grunt, the LIFT KEY, and back up to B3F below its Rare Candy. Celadon's Center has no map file, so its coded ground floor is added to the story maps and the plan walks out of it as 00.30 walks out of Lavender's. A step north onto the Grunt's tile after his battle (he is removed by the script); B2F goes round east of the turning Grunt (20, 6) and up column 21 to the stairs. The fault sweep and the row test hide a talk-started battle's trainer once the script removes them (talk_battle_hide_flag()). The story-wide tests count 00.31; the sim trace golden gains its lines only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
… for code health Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…t B3F stairs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
… to 3 tiles per tile Rocket Hideout B3F's west 7 off the stairs from B2F ended short on console B (00.31 r1); the check skipped it since the hold to the west wall and back walks 18, over 2 per tile. The red sim test now passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…ing the sim tests under 1000 lines Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…, off the header's symbol count Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
00.31 r1 run 3 (console B): on Rocket Hideout B3F, "south 2" from (1, 14) ended a tile short; "east 2" onto the arrow (3, 16) walked into the wall instead, the next position check mistook that wall for the one at (7, 20), and the later legs slid the player to the stop tile (10, 13). An open leg followed by a slide is now checked like one followed by a wall hold. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…tap a tile Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…ps and short-hold sweep test
…ng AutoStoryEvents.cpp under 1000 lines
…f AutoStoryEvents.h's symbol count
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
From the Grunt's line to below the LIFT KEY and on to B4F's stairs (11, 15) are now taps legs, one checked tap per tile; below_lift_key keeps a turn-only route to face the key and b3f_from_b4f only climbs the stairs. The sweep checks run them with each turn dropped and the stairs with any hold short. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
A black that clears with the old scene back is no warp: wait_out_warp() now compares the screen after the fade with one taken before the hold (warp_left_scene()) and fails 'warp to X not confirmed'. Sim fault black_without_warp and rule confirm_warp_destination, with WarpFade cases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Owner
Author
|
Superseded by #345 (rebuilt on stage 8 JSON) |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #319 (base
frlg/story-0030; the diff shows only this change).Promotes the 00.31 draft to
StoryData/: from Celadon's Pokemon Center, the Game Corner's poster Grunt, the poster switch, the hideout down to B4F's Lift Key Grunt, the LIFT KEY, and back up to B3F below its Rare Candy. Celadon's Center has no map file, so its coded ground floor (pokemon_center_room()) is now added to the story maps and the plan walks out of it like 00.30 walks out of Lavender's. Changes from the draft: a step north onto the poster Grunt's tile after his battle (the script removes him), and B2F goes round east of the turning Grunt at (20, 6), then up column 21 to the stairs, so only the Lift Key Grunt is fought on the way. The fault sweep and the new row test hide a talk-started battle's trainer once the script removes them.B3F's arrow floor now follows pokeguy's path (LeafGreen 1:59:34, https://www.youtube.com/watch?v=CbfjWuRWH10), hard-coded as
tapslegs: on foot, one tap per tile, each checked by the screen scroll (up to 3 taps, because the first tap of a leg may only turn the player), and the slide waited out after a tap onto an arrow. Video times per leg, from frames sampled at 2-4 fps (tiles checked against the pret B3F map and its coded arrows):The way down is no longer planned, so the fragile holds from the last sweep are gone. The new Hideout sim test runs both tap lists with each turn tap dropped in turn, and runs the two planned routes that are left (onto the stairs to B4F, east to the Rare Candy) with each hold 1 or 2 tiles short. All runs end on target. fixed_route() moved unchanged into AutoStoryLegs.cpp/.h, with spinner support added; review it with
git diff --color-moved.Testing: headless SerialProgramsTests for PokemonFRLG::AutoStory, PokemonFRLG::Overworld and Pokemon:: all pass except the local missing-resource/image cases. The 00.31 row passes on the sim, every 00.31 fault sweep passes (30 game-odds seeds) and the sim trace golden gains only 00.31's lines. Not run on a console yet.
🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss