Repository navigation
FRLG AutoStory 00.30-00.32 on stage 8's JSON: Celadon, the Rocket Hideout, the SILPH SCOPE - #345
Merged
Merged
Conversation
00.30 (Lavender to Celadon on the Bicycle, the Route 7 Pidgey), 00.31 (the Game Corner poster to B4F's LIFT KEY and B3F's Rare Candy) and 00.32 (the lift, the door guards, Giovanni, the SILPH SCOPE) as JSON checkpoints in stage 8's format, phase "testing"; 00.31 carries its postconditions in its metadata. Ported from the old drafts onto stage 8's code: the field GAME actions (register_bike, ride_bike, use_item, poster_switch, lift_floor, the Pokemon Center room scripts), bike and tap legs, the spinner floors in the walker and sim, pacing that dismounts in grass and keeps its spot (#319), B3F/B4F as per-tile taps (#326), the warp destination confirm by before/after frames and the talk-box check, with the sim's black_without_warp fault test (#327). The actions are specs in FRLG's table, read against stage 8's args. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
marked this pull request as ready for review
November 10, 2026 20:29
This was referenced Nov 10, 2026
Closed
dayfine
added a commit
that referenced
this pull request
Nov 11, 2026
…ktunnel Stage8 rebuilt 00.30-00.32 as JSON (#345) and supersedes the story-0030/31/32 line this branch was on. The tree is taken whole from frlg/part-ids-stage8, the same renumbering redone on stage8. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
frlg/stage8-rocktunnel(#293). Diff shows only this change. Supersedes #294–#303, #314, #319, #326 and #327.FRLG checkpoints 00.30 (Lavender to Celadon on the Bicycle, the Route 7 Pidgey), 00.31 (Game Corner poster to B4F's LIFT KEY and B3F's Rare Candy) and 00.32 (the lift, door guards, Giovanni, SILPH SCOPE) rebuilt as JSON in stage 8's format, all
metadata.phase: "testing"; 00.31 lists its postconditions (RocketHideout_B3F (12,13) facing north, LIFT_KEY 1, RARE_CANDY 2) undermetadata.postconditions, which the FRLG reader now accepts and checks for shape.The code from the old drafts is ported onto stage 8's step args rather than merged: the field GAME actions (register_bike, ride_bike, use_item, poster_switch, lift_floor, the Pokemon Center room scripts) are specs in FRLG's action table; bike and tap legs; spinner floors in the walker and sim; pacing that gets off the Bicycle in grass and keeps its spot (#319); B3F/B4F as per-tile taps (#326); the warp destination confirm by before/after frames and the talk-box check, with the sim's black_without_warp fault test (#327). Dropped: story-json's parser, sim trace and C++ table builders (stage 8 has its own; the builders the tests need are in
PokemonFRLG_AutoStoryFieldSteps), and the 00.32b–00.51 drafts of #295–#303, which stay on their branches for when those stages are built.Testing: build, code health 0 against the stage branch, and
--command-line-test-mode --profile unit-testsfor the FRLG AutoStory, Overworld and Pokemon::Story suites, including the 00.30–00.32 sim rows; only the known image FileException failures remain.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss