Repository navigation
Conversation
Unverified authored-checkpoint drafts, outside the embedded StoryData set: the Lavender Mart, Route 8, the Underground Path, a Pidgey for Fly, and the Rocket Hideout to Giovanni. The README lists the whole 00.29-00.51 draft, its conventions, the user's open decisions and the leg check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…g/draft-story-29-31
… aren't rows #293's 00.29 (Route 10 to Lavender's nurse) passed on the console, so the draft that reused the id is dropped. The README says what blocks 00.30 and 00.31 from becoming table rows: no Celadon or Rocket Hideout maps in the locked runtime pack, no row to Celadon's Center, no spinner or lift step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
… on the sim Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…t's trainers Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…case table Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…0.32; the steps and maps they need Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…the poster Centers share one layout and the lift is 5x7 tiles, so the story walks them by fixed taps (center_enter, center_exit, lift_floor from below the door to the destination's door) and the sim builds their rooms from code read off pokefirered. B2F/B3F spinner tiles and the Game Corner poster and stairs are coded too, so the candidate maps need no extra regions or objects. Bike pace and bag waits from console B (2026-11-09). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
From Lavender's Center: the Mart's Escape Ropes and Super Repels, Route 8 on the Bicycle with only Gamer Rich fought, the Underground Path, a Pidgey from Route 7's grass, and Celadon's Pokemon Center. The plan loader accepts the bike, Center, item and hideout variants from the merged drafts; the sim stubs a Center's way in when the Center has no map, and the fault sweep ends a row there. Route 7 and Route 8 get their land rates in the sweep; the story sim trace golden gains 00.30. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The run plans, the checkpoint count, Rich among the trainers fought, a bike leg after the BICYCLE, and the Pidgey's route ending on the first grass tile; the sim trace golden regenerated with the stub report whole. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
On the bike a tap never only turns the player: it takes a step. The walker's turn tap before each leg made every open leg one tile long on the bike, and 00.30's walk to Route 8 ended on Route 12 (console B, 2026-11-09). turns_first() now skips the tap on the bike, for the walker and the sim walker alike. The sim models the bike: a tap steps facing either way, a hold through a turn loses no tile, and no step tap is ignored. Bike holds measured on Route 12's pier go in the movement mechanics table. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
#314 moved the GAME steps' arguments into args; the next commit moves 00.30's steps and the use_item and lift_floor actions over. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The use_item and lift_floor actions read their item and floors from StoryStep::args and declare them in the action table, as #314's actions do. 00.30's Mart and capture steps and the draft plans are converted; the sim trace is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Holds counted back with one-tile taps on console B (Lavender Town, 2026-11-09) moved a tile per 100ms from rest, the same each time. At 112ms a tile, 00.30's "west 16 (open)" on Route 8 went 17 or 18 tiles and the walk missed the Underground Path's door. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Console B, 2026-11-09: three 00.30 runs stood 3 tiles east of the walker's belief after Route 8's open legs, the hold north to the Underground Path's door ran up to the cliff (16, 2), and the step onto the door bumped the house. The test starts the steps after Rich's battle from tiles up to 3 off the table's and expects Route 7 with no trainer met. Red on the current plan: from (45, 7) it fails as the console did. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The open legs from (48, 7) to (14, 13) had no wall between them, so an error anywhere on them reached the door. Now row 7 is held west to its wall (26, 7), column 26 south to the bottom wall, and row 14 west to its wall (12, 14); from there 2 Bicycle taps east and a hold north to the house's wall (14, 5) put the player below the door. Each hold that ends on a wall puts the player back on a known tile, so a start up to 3 tiles off still reaches the door. The golden trace changes only for events 14 and 15, which are new. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Console B, 2026-11-09: on the Bicycle a 40ms tap is always one tile, tap chains are exact at one per 100ms and drop one tap in 12 at one per 60ms, and the registered Bicycle gets on with SELECT in about 1s. Open legs on the Bicycle are now walked a tap at a time (40ms press, 120ms period, judged after a settle by the screen scrolling). A tap that doesn't move ends the leg blocked: run_route() finds the player on the tiles the count gives, up to 3 further for a start that was off, ahead of a block. An interrupted tap ends it with the count and one more. A warp takes the walker off the Bicycle; the next leg where it may be ridden gets on again with SELECT, checked by the standing sprite no longer showing. The sim models the taps (dropped under 80ms), SELECT and doors. New OverworldBike tests: tap chains, an 11-tile leg from a start 2 off (red with one hold), SELECT onto the registered Bicycle, speed after a door. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
A new GAME step, register_bike, REGISTERs the BICYCLE from Key Items (its menu's second option) once a save. It sits at the start of 00.30's plan until 00.26's plan (frlg/stage7-celadon, #224) can take it right after the Bicycle. ride_bike now gets on with SELECT (MINUS) and checks the player rides (get_on_bike()) instead of using the bag. The golden story sim trace gains register_bike's three lines and its stub, and 00.30's later events are numbered one up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…line The sim's taps (turn, step, Bicycle) move to PokemonFRLG_OverworldSimTaps.cpp, SELECT goes through use_field(SimField::BIKE_SELECT), the counted taps are chosen in walk_and_watch(), and each new constant has its own comment. The golden trace places register_bike where 00.30 starts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
count_bike_taps() and its types move to PokemonFRLG_OverworldBikeTaps.h/.cpp, BikeSelectCalls loses its log, and the Bicycle tests' expectation is a std::string. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
… out of Route 7's grass Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…ast battle left the player Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The newer code-health rules (header symbol counts, no char* / char[]) failed 41 times against frlg/story-json. Declarations move unchanged into headers by concern (Pokemon Center room, hideout lift room, bike and spinner mechanics and presses, overworld spin, sim field, overworld bike, bag, bag use, room legs, field steps, hideout lift); char* constants and parameters become std::string_view or std::string. No behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This was referenced Nov 10, 2026
Owner
Author
|
Superseded by #345 (rebuilt on stage 8 JSON) |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #314 (base
frlg/story-json, with #294frlg/draft-story-29-31merged in for its bike, Center and item steps; the diff shows #294's changes too until it lands in the stack).The story stopped at Lavender's Center. This adds 00.30 as
StoryData/frlg-00.30.plan.json, from Lavender's Center to Celadon's, in six sections: the Lavender Mart (4 Escape Ropes, 7 Super Repels), Route 8 on the Bicycle with only Gamer Rich fought, the rest of Route 8 by waypoints that keep out of Glenn's and Aidan's lines, the Underground Path, a Pidgey in Route 7's grass, and Celadon's Center. Open legs end on walls or in funnels (Julia's column, the wall west of Lavender's exit). There's no Repel because the way never crosses grass, apart from the Pidgey's patch. The plan loader now accepts #294'sbike, Center, item and hideout variants. The sim stubs a Center's way in when the Center has no map (Celadon's isn't in the map pack), and the fault sweep lets a row end there. Celadon is added to the save card places, and the Lavender Mart to the loaded maps.Testing: on the headless runner, the 00.30 row passes on the overworld sim (only Rich fought), and so do a wild battle on the step into Route 7's grass and the save place. All five fault sweeps run 00.30 clean, with Route 7/8 land rates added, and the known-failing list has nothing for 00.30. The sim trace golden gains 00.30.
PokemonFRLG::AutoStoryandPokemonFRLG::Overworldfail only the known image tests, plus one Resources file missing from my local Packages. Nothing ran on a console.Update: merged #314's structured args. 00.30's Mart and capture steps and the drafts'
use_item/lift_floorsteps are converted, and those two actions readargstoo. Ause_itemwith aslot(Rare Candy) is still refused, as before. The FRLG andPokemon::suites pass on the headless runner apart from the known image tests and the local Resources check, and the golden trace is unchanged.Update: merged the bike-taps and Pidgey-pacing work. Open legs on the Bicycle outdoors are counted out in taps, each a tile, and the walker gets back on with SELECT after a door. The Route 7 capture is paced so the player stays in the grass. The last commit (acc74a7) only fixes the newer code-health rules: over-limit headers are split by concern, with declarations moved unchanged (
git diff --color-moved=dimmed-zebra acc74a77e~1 acc74a77e), andchar*constants and parameters becomestd::string_vieworstd::string. After it,PokemonFRLG::AutoStory,PokemonFRLG::OverworldandPokemon::fail only the known image tests and three files missing from my local Resources.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss