Repository navigation
Conversation
A fault-class sweep for fixed waits after a fade: with SimWorldKnobs::slow_fade_in, a walk, tap or door run after a door's fade or a tap step's way through, with no settle() between, fails (lab-B 2026-11-10, 00.04b heal_sandgem). FaultClass::SLOW_FADE_IN runs it over every row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The fixed-wait audit (lab-B 2026-11-10, 00.04b heal_sandgem) found three more places that waited a fixed time after a fade and then moved: - A tap step's way through (to_banner) waited 1000 ms and the next step walked; the slow fade-in sweep failed 01.02 and 01.05 there. It now settles (talk_over()), on the "through already" path too. - run_into_center() settled only after a seen fade; the "inside" and lined-up ways in walked to the nurse at once (or after enter_lit_door()'s 1500 ms). Every way in settles now. - walk_out_of_center() (Oreburgh's whiteout) waited for daylight plus 1000 ms; it settles too. A sim case checks a Center's inside settles in bounded time: visitors walking past read still (under WALK_TAP_BLOCKED_CHANGE), so 5 s after the fade; a screen never still ends on the 15 s calm rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Code health: no char* in the Center settle case; the new labels built with std::format. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The quiet is judged a look (a press) or two after it starts: the still case ends 7680 ms in, past the 7500 ms bound. 2000 ms of slack. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…ttle Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…ttle Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…ttle Brings #128's seam work down through #167 and #226. No conflicts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…ttle Picks up #226's code-health fixes after the #128 merge. No conflicts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
that referenced
this pull request
Nov 12, 2026
Brings #128's seam work down through #167, #226 and #364. No conflicts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This was referenced Nov 12, 2026
dayfine
added a commit
that referenced
this pull request
Nov 12, 2026
…with #128) into lab/dev-bdsp Brings #128's seam work (StoryRun shell, start gate, golden plans, fault sweeps) to console B's branch through #167/#226/#364/#375 and #400. No plan file changes: every BDSP plan JSON stays as lab/dev-bdsp had it. Conflicts: - PlannedRoute_Tests.cpp: theirs. This branch's extra lines were the cherry-picked SimulatedRouteIO and its blocked-from-several-tiles case, now in SimulatedRoute_Tests.cpp on #375. - CommonFramework/Main.cpp: keep this branch's cleanup after the command-line test mode return (headless runner), with main's PA_SDL gamepad tracker stop added to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #226 (base
bdsp/autostory-mine-floaroma-wip; the diff shows only this change).This audits every fixed wait in the AutoStory code that comes after a fade, door or scene and is followed by a move (the 00.04b heal_sandgem fault, lab-B 2026-11-10). It fixes the BDSP cases with the same settle rule as #226:
talk_over(), which waits for the fade to finish and the screen to go quiet, with a time limit.to_banner) waited 1000 ms and then the next step walked. It now settles, also on the path where the walk before already went through.run_into_center()settled only after a fade it saw. When the run saw no fade but was already inside, or lined up on the door, it walked to the nurse with no settle. Now every way in settles.walk_out_of_center()(Oreburgh whiteout) waited until the screen was bright, then 1000 ms. It settles now.SLOW_FADE_IN: any move after a warp with no settle in between fails.waitsteps, keyboard 3 s, not changed)Detectors that can fire falsely during a fade: battle cues and battle text (00.04b); the walk's "transition" check, where a fade-in reads as a scene change; dark frames read as "no box"/still (SceneJudges already guards this); "no Center floor" on black; "brightness > 40" taken as settled. FRLG:
warp_left_scenecomparing a frame that is still fading in. The full table, with file:line for each wait, is in~/BDSPLab/notes/2026-11-11-fixed-wait-audit.md.Open risk: the inside of a Center has NPCs walking about, and talk_over only ends once the whole screen is still. A visitor walking past changes the screen by 10–13.4, under the stillness threshold of 16, so it still counts as still. The settle should end about 5 s after the fade, and a screen that never reads still ends on the 15 s calm rule. A new sim case checks both bounds. This was not measured on the console.
Testing
SLOW_FADE_INsweep was red on 01.02 and 01.05. Both fail on the walk right after ato_bannerstep. With the fix, every row it sweeps is green. 00.01, 00.04 and 01.11 already fail without any fault injected, so the sweep skips them.--filter PokemonBDSP), before (WIP: BDSP AutoStory: Oreburgh Mine map alignment, corridor legs, and Floaroma pathing #226 tip) and after: base 235 passed / 68 failed, after 258 / 69 (the new sweep and the Center settle case are the extra tests). None of the 303 tests in both runs changed status; the failures are fork-only images and story-sim rows that already fail on WIP: BDSP AutoStory: Oreburgh Mine map alignment, corridor legs, and Floaroma pathing #226. Both runs hung at the same tests (Pokemon::Transitions - captured frames: PokemonBDSP,00.04: the walk to the Poke Mart lady and back) and were stopped there. The Center settle case passes after the slack fix (00d0d9b). It settles 7680 ms after the door when the visitors read still and 17920 ms when the screen is never still.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss