Repository navigation
Conversation
…with wall recovery
…k safeguard - StoryWorld: add wander_hazard tracking and wandering_hazard(world, pos) helper to distinguish wandering areas from impassable walls. - RoutePlanner: add per_wander_tile = 3 penalty to TilePlanCosts so paths through wander boxes are preferred over long detours while still favoring open streets when distances are equal. - StoryWalkSteps: do not pass wandering hazard boxes into plan.avoid, preventing RouteWalker from uncovering and severing main thoroughfares such as Oreburgh City column 46. - Walk: raise WALK_BLOCKED_CHANGE to 16.0 to detect running in place against obstacles and wandering NPCs rather than running to timeout. - PlannedRoute: bound tiles_moved when stop == WalkStop::LIMIT by moved_chunks, and add distance safeguard in check_at_wall requiring at least 70% of expected distance traversed before verifying arrival. - GridSim_Tests: add multi-seed test for Oreburgh City north route, test custom map check_at_wall safeguard against stalled legs, and update above_the_mine test to path through wander zones.
Check for the Center's inside before lining up on a lit door, give run_into_door's black-screen watcher a 50 ms hold and log which watcher fired, and target the map's pokemon_center_doorstep point below the Center's door. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The welcome leaves the party as Route 203 left it, and every reload of 01.03 replayed a paralysed lead with no PP on its water move. New row 01.02b walks from the welcome to the Center and heals; 01.03 now starts on the Center's doorstep and routes west to Barry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
PlannedRoute_Tests.cpp held the scripted-console cases and, since the #128 merge, its simulated-console cases too, at 975 of 1000 lines; #400's next case would not fit. SimulatedRouteIO and the cases that use it (blocked from several tiles, the Jubilife Center walks, the story-route fault sweep) move unchanged to SimulatedRoute_Tests.cpp, under the same test names, with their own case table. Review with: git diff --color-moved HEAD~1 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
that referenced
this pull request
Nov 12, 2026
…dsp/start-certainty Brings #128's seam work down the BDSP console stack. Conflicts: - bdsp-00.05.plan.json: ours, byte-identical to lab/dev-bdsp (console truth). #128's side is 2fe00a0 (legs rewritten as routes: content, not a format change), which this branch's 00.05 rewrite supersedes. - PlannedRoute.cpp: both new RouteWalker functions, mark_tiles_past() (#128) and held_up_on_the_way() (this branch), in lab/dev-bdsp's order; the file equals lab/dev-bdsp's. - PlannedRoute_Tests.cpp: the case table keeps this branch's held-up wall leg case; the Jubilife held-overshoot case moved with SimulatedRouteIO to SimulatedRoute_Tests.cpp in #375. All plan files equal lab/dev-bdsp's after the merge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
that referenced
this pull request
Nov 12, 2026
…with #128) into lab/dev-bdsp Brings #128's seam work (StoryRun shell, start gate, golden plans, fault sweeps) to console B's branch through #167/#226/#364/#375 and #400. No plan file changes: every BDSP plan JSON stays as lab/dev-bdsp had it. Conflicts: - PlannedRoute_Tests.cpp: theirs. This branch's extra lines were the cherry-picked SimulatedRouteIO and its blocked-from-several-tiles case, now in SimulatedRoute_Tests.cpp on #375. - CommonFramework/Main.cpp: keep this branch's cleanup after the command-line test mode return (headless runner), with main's PA_SDL gamepad tracker stop added to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The grid sim holds east and west at a walk at 200 ms a tile (fe2da03), slower than the walker's 160 ms. The pace was private to GridSim.cpp, so a hold timed elsewhere (the Monte Carlo's disturbed_hold()) could not use it. No change in behavior. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
"no hand-written legs but the listed ones" listed ten LEGS steps, six of them gone from the table, while the start-certainty rows added wall legs (00.01 onto_the_flute_tile, 00.05 east_to_the_wall, ...) that each give their reason in the step's "why". The test now asks that of every LEGS step instead of a list kept beside the table. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
that referenced
this pull request
Nov 12, 2026
…s say why) into bdsp/start-certainty
dayfine
added a commit
that referenced
this pull request
Nov 12, 2026
… steps say why) into lab/dev-bdsp
Brings in 9223d35, which registers the BDSP Dialog/Menu detector suites once; the runner aborted on Duplicate Test Name without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
that referenced
this pull request
Nov 12, 2026
…carlo Picks up the single registration of the BDSP Dialog/Menu detector suites. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
that referenced
this pull request
Nov 12, 2026
Picks up the single registration of the BDSP Dialog/Menu detector suites. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
that referenced
this pull request
Nov 12, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
that referenced
this pull request
Nov 12, 2026
…er) into bdsp/start-certainty BDSP's robust routes now plan on Pokemon::plan_robust_legs. The held open legs this line added to BDSP's own planner (#375: hold_open_legs, per_open_grass_tile, open_hold_error(), TileLeg::held) move into the shared planner as RobustLegCosts::hold_open_legs / per_open_wild_tile and RobustLeg::held, off by default, so BDSP plans the same legs as before. SourceFiles.cmake keeps both sides' new files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The step came in with the bdsp/sim merge (#264) and was never on bdsp/autostory-v4. v4 rewrote StoryData/*.plan.json in the #312 format: steps carry action + args, poses are {map, facing, tiles}, and the file has a metadata block. No PokemonSimulation revision reads that format (913a5e3 and main 438b672 both reject the top-level keys, and pose and step shapes differ too), so the step could only fail. The workflow now matches bdsp/autostory-v4; restore the replay once the simulator reads the v4 plan format, with a new pin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…_name) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
… on literal temporaries) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…table_step, stray using namespace detail) and header_symbols tag on RouteTiming.h Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…ion templates The AutoStoryResources test found 22 Autostory/Options PNGs missing in CI: they are not in PokemonAutomation/Packages master. dayfine/Packages bdsp/autostory-options is upstream master plus exactly those files. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…story table route_plans.golden.txt and PlanGolden.h predated the merge: they lacked 00.02 to_the_lake_entrance, 00.05b past_the_president, 01.02 south_to_the_cliff and 01.08 west_to_the_wall, and still stored 00.01 onto_the_flute_tile. Both tests fail identically on macOS with the CI-pinned maps, so this is not CI data. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…osts The queue compared costs only, so equal-cost spreads came off the heap in the standard library's order: macOS planned 'north 1; west 2; south 1' round a wander zone and Ubuntu 'south 1; west 2; north 1'. Equal costs now go to the lesser spread (north to south, west to east). A second case pins the east side. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #128 (base
bdsp/autostory-v4); the diff shows only this stage. #262, #305, #311 and #400 stack on it.This is the BDSP console stage from Oreburgh to Floaroma, folded from #167 (grid simulation of walks and scenes), #226 (Oreburgh Mine alignment, corridor legs, Floaroma pathing, the shared action table and between-step interrupts), #364 (settle after every way through instead of fixed waits) and #375 (short door settle in Centers, one run to the nurse); those PRs are closed and keep their discussion. It now carries #128's seam work (StoryRun shell, start gate, golden plans, fault sweeps); where a BDSP plan file conflicted it keeps the version console B runs on
lab/dev-bdsp, and each merge commit lists those decisions. Two pieces of our own code moved, unchanged, to keep files under the 1000-line limit: the story sim's trigger tables toSimTriggers.cppand the simulated-console route tests toSimulatedRoute_Tests.cpp(git diff --color-moved 0405c90e5~1 0405c90e5and the same for 3521c81). Tested with the headless runner onlab/dev-bdsp(153e32f), which merges this branch through #400:PokemonBDSP::AutoStorygives 353 passed / 10 failed, the same nine known failures as before (seven Monte Carlo rows, the old 01.03 and the hand-written-legs list) plus #128's new "fault sweep: every story route with timed holds overshooting", which the console-run plans do not pass yet.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss