Repository navigation
FRLG AutoStory: run on the shared story-run start and finish - #382
Merged
Merged
Conversation
The start's save load, the reload between attempts and the finish of a run or verify run go through Pokemon/AutoStory's shell. FRLG lends its soft reset, the save card's place check and the bag reread; the failure line is now the same as BDSP's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Supplies the shared story run's preflight (read_story_preflight): the program checks it before its first press (SID Helper's name, the TID read), and every start, new game and live ones included, now goes through prepare_story_start, which logs the checkpoint actually starting. A failed preflight is a setup error with nothing pressed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #293.
FRLG AutoStory now runs on the shared story-run start and finish from #380, like BDSP in #381. The start's save load (normal and verify mode), the reload between attempts, and the end of a run or verify run go through the shared code; FRLG lends its soft reset, the save card's place check against the checkpoint's start map, and the bag reread. Behavior is unchanged apart from the log lines: "[Story] 01.03: loading the save" replaces "Loading the save for 01.03.", and a failure now logs "AutoStory failed: the game stays where it failed." as BDSP does. Tested with the Pokemon::StoryRun suite in the headless runner and a compile of the program; not run on the console.
🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss