Skip to content

PokemonFRLG AutoStory: sim goldens for the overworld sim (seam 3, S3-0) - #420

Draft
dayfine wants to merge 7 commits into
frlg/stage8-rocktunnelfrom
frlg/sim-goldens
Draft

dayfine wants to merge 7 commits into
frlg/stage8-rocktunnelfrom
frlg/sim-goldens

Conversation

@dayfine

@dayfine dayfine commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

Depends on #419. Base: frlg/stage8-rocktunnel (#293), with nav/sim-goldens (#419) merged in; until #419 lands there the diff also shows its files, and the nav/grid-story-steps (#362) commits #419 is based on that this stack had not merged yet (ScreenMachine, ZonePose, ScreenObservation, Pokemon_Grid.h). Read only the PokemonFRLG_AutoStorySimGolden_Tests.*, sim_golden_*.txt and the one registration line.

Records what FRLG's overworld sim does with every row of the story as goldens, so seam 3 can move the sim onto the shared core (fault counters, clock, body) and show nothing changed.

  • sim_golden_rows.txt: each row with a start, run clean on OverworldSim through OverworldStepSim: where each step leaves the player, the maps it warped from, its failure, and each sim stretch's clock, counters (steps, warps, wild battles, signs, dropped/ignored taps), trainers beaten, violations and the screens it showed with their times.
  • sim_golden_faults.txt: the fault sweep's result and logged lines for every row and fault class, captured by running add_tests_AutoStoryFaultSweep()'s cases (no sweep code is copied).
  • Registered from add_tests_AutoStorySimulation(); rewrite both with PA_UPDATE_SIM_GOLDENS=1.

Testing: headless runner, Sim golden and PokemonFRLG::AutoStory - Simulation suites: 66 passed, 0 failed; the goldens were written once and then checked on a second run. The golden test takes about 45 s, mostly the fault sweep run again.

🤖 Generated with Claude Code

https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

dayfine and others added 5 commits November 12, 2026 00:36
What the overworld sim does with each row of the story, kept as goldens
so seam 3 can move FRLG's sim onto the shared sim core and show nothing
changed: each row run clean (where each step leaves the player, warps,
failures, each sim's clock, counters and screens), and the fault sweep's
outcome for each row and fault class.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…tion tests

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine and others added 2 commits November 13, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant