Repository navigation
Conversation
… for the sims Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…s are the shared ones OverworldSim counts SimScript's injected faults with Pokemon::SimFaults (turn taps as LOST_TAP, moved step taps as UNSEEN_STEP, steps onto a warp as WARP_NO_OP) instead of its own counters; the fault sweep uses Pokemon::FaultClass and keeps its own names for the sweeps, so the test names and goldens stay as they are. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…h: OverworldSim.cpp size) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #420 and #422. Base
frlg/sim-goldens(#420), withnav/sim-faults(#422) merged in; the diff shows #422's sharedPokemon_SimFaultsfiles plus this change.FRLG's fault sweep had its own
FaultClassenum, andOverworldSimcounted turn taps, moved step taps and steps onto a warp with its own ints againstSimScript'sstd::set<int>s. The sweep now usesPokemon::FaultClassand keeps its own sweep names insweep_name(), so test names and goldens don't change. The sim counts those chances withPokemon::SimFaults, whichSimScript::faults()builds from the same sets (turn taps asLOST_TAP, moved step taps asUNSEEN_STEP, warp steps asWARP_NO_OP), so tests that set the sets are unchanged.Tested with the headless runner:
Sim golden,Sim faultsandPokemonFRLG::Overworld, 137 passed. Both FRLG goldens are byte-identical. The one failure,OverworldSpin - lift lets out on the floor picked, also fails on #420's CI and isn't from this change.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss