Skip to content

FRLG AutoStory: the sim and the fault sweep use the shared fault counters and classes - #424

Closed
dayfine wants to merge 5 commits into
frlg/sim-goldensfrom
frlg/sim-faults
Closed

dayfine wants to merge 5 commits into
frlg/sim-goldensfrom
frlg/sim-faults

Conversation

@dayfine

@dayfine dayfine commented Nov 12, 2026

Copy link
Copy Markdown
Owner

Depends on #420 and #422. Base frlg/sim-goldens (#420), with nav/sim-faults (#422) merged in; the diff shows #422's shared Pokemon_SimFaults files plus this change.

FRLG's fault sweep had its own FaultClass enum, and OverworldSim counted turn taps, moved step taps and steps onto a warp with its own ints against SimScript's std::set<int>s. The sweep now uses Pokemon::FaultClass and keeps its own sweep names in sweep_name(), so test names and goldens don't change. The sim counts those chances with Pokemon::SimFaults, which SimScript::faults() builds from the same sets (turn taps as LOST_TAP, moved step taps as UNSEEN_STEP, warp steps as WARP_NO_OP), so tests that set the sets are unchanged.

Tested with the headless runner: Sim golden, Sim faults and PokemonFRLG::Overworld, 137 passed. Both FRLG goldens are byte-identical. The one failure, OverworldSpin - lift lets out on the floor picked, also fails on #420's CI and isn't from this change.

🤖 Generated with Claude Code

https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

dayfine and others added 4 commits November 12, 2026 01:01
… for the sims

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…s are the shared ones

OverworldSim counts SimScript's injected faults with Pokemon::SimFaults
(turn taps as LOST_TAP, moved step taps as UNSEEN_STEP, steps onto a warp
as WARP_NO_OP) instead of its own counters; the fault sweep uses
Pokemon::FaultClass and keeps its own names for the sweeps, so the test
names and goldens stay as they are.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…h: OverworldSim.cpp size)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine

dayfine commented Nov 15, 2026

Copy link
Copy Markdown
Owner Author

Closing: #458 (d917810 and later) carries the FRLG seam fault sweep; the SimFaults counters and shared runner are queued on #458.

@dayfine dayfine closed this Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant