Repository navigation
Conversation
…d badge check The walk up the Oreburgh Gym was blocked by the second trainer, an A press opened his talk and it was fought as Roark (lab-B 2026-11-12 22:50): 01.04 passed and 01.05 saved with no badge. The opponent is now the next one in line (GymTrainers: Roark only once both trainers are beaten). When CHECKS is thorough or testing, verify_badge() opens the Trainer Card after the leader's battle and fails on a missing badge. The shared verdict is Pokemon_BadgeCheck.h, for FRLG to reuse. The BDSP reader has no fixture yet and reads UNREADABLE (passes, with the card's screenshot kept in Screenshots/AutoStory/cards/). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…dable Trainer Card fails the badge check Roark was taken for a gym trainer after a reload (lab-B 2026-11-12 23:49), and the replacement, GymColumn (tiles from time walked), is dead reckoning too. Now BattleIntroWatcher reads "You are challenged by Gym Leader Roark!" against "... by <class> <name>!" in the battle's text box while it shows (English only; UNREAD otherwise), fight_story_battle() returns it, and the gym step fails with a screenshot when the intro was not read instead of guessing. GymColumn stays as a log hint and for how long to wait for Roark's battle. The Trainer Card check now fails on an unreadable card (no fixture exists yet, so the reader is still a stub). PotionLedger from 333dc87: Potions stop after one that gained no HP. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…anguages at the start The French run (lab-B, 2026-11-13 01:17) never read the intro: the reader was English-only, so two gym battles were fought blind and the Roark check failed after them. The intro classifier now takes per-language word tables (English, French; accents folded), 01.04 refuses at its start in a language with no table, an unread intro dumps its frames to DebugDumps, and the log line reads "opponent: not read". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…s intro text The intro text was read by OCR in English and French only; Roark is the gym opponent who talks on the overworld after the battle (badge and TM speech), while a gym trainer's battle ends on a quiet overworld. talk_over now counts the looks with a box (TalkOverTally), the battle returns that count, and gym_opponent_after_battle() decides. BattleIntro is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
that referenced
this pull request
Nov 13, 2026
…eck, breakpoints, 01.10 wall legs by a wander zone Folds what lab/dev-bdsp gained after acb34a2: #449 (Roark told by the talk after the battle, TalkOver box tally, Trainer Card badge check), the #432 walker fix 697e769 (a wall leg by a wander zone tells the wall from the wanderer; 01.09/01.10 start rows; start-pose screenshots; regenerated route goldens; 01.10 start sweep stays known failing), and the AutoStory breakpoints with their lab pause wait. Conflicts: PokemonBDSP_AutoStory.cpp keeps rebuild/src's run plan and Starter RNG hook and adds the check level and the breakpoints; StoryEnv holds both checks and run_starter_rng; the two test files take both sides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This was referenced Nov 13, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #432 (base: bdsp/wanderer-zone-stand; the diff shows only this change).
01.04 passed without beating Roark (lab-B 2026-11-12 22:50): the walk up the gym was blocked by the second trainer, an A press opened his talk, and it was fought as "Roark". Now the opponent is the next one in line (
GymTrainers): Roark only once both gym trainers are beaten, whatever the walk met. When CHECKS is thorough or testing,verify_badge()opens the Trainer Card after the leader's battle and fails the step if the badge is missing; the verdict is shared (Pokemon_BadgeCheck.h) for FRLG to reuse. No BDSP Trainer Card screenshot exists (CommandLineTests, lab), soread_trainer_card_badge()reads UNREADABLE (passes) with a TODO, and the card's screenshot is kept inScreenshots/AutoStory/cards/for the fixture.Testing: headless runner, suites "01.04 gym" and "badge check" pass; no console run.
🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss