Repository navigation
Lab: describe_program lists the program's prechecks (Slice 4) - #511
Merged
Merged
Conversation
ProgramInstance gains precheck_summaries(): the program's prechecks in the order it runs them (name, needs, skippable), or nothing when it declares no list. describe_program prints them under "prechecks", or "unsupported" as before. No program declares a list on this branch yet; FRLG RNG's list (fork #485) overrides it once that reaches lab/tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
lab/tooling; the diff shows only this change. Part of #131 Slice 4 (follows #504).describe_programalways printed"prechecks":"unsupported", because a program had no way to say which checks it runs.ProgramInstancenow hasprecheck_summaries(): the program's prechecks in run order, each a name, a one-line "needs" and whether the user can turn it off, or nothing when it declares no list.describe_programprints the list as[{"name","needs","skippable"}](an empty list means the program needs nothing); without a list it still printsunsupported. No program overrides it on this branch: thePrechecklist and FRLG RNG's checks (#485) live onupstream/frlg-free-party-slots, which lab/tooling does not contain yet. Tested with new cases in the CommonFramework::LabProgramContract unit tests and a syntax-only compile of the touched files; no console run.Code health: 1 advisory failure,
ProgramSessiongoes from 26 to 27 public methods (the accessor that reads the instance's list).