Repository navigation
Conversation
dayfine
left a comment
There was a problem hiding this comment.
Reviewed SHA: d245b9d
Verdict
NEEDS_REWORK
First-pass review of this PR's own diff against plza/upstream/s2-02. Code health: 0 failures (5 advisories). Fork Draft CI build passed; the ubuntu job was still pending when read.
High
- Nothing in the chain calls the new runtime code. At the chain tip (#545,
plza/upstream/s2-11),run_watched,watch_for,CoveredWatcher,TalkOverandnote_warpare used only by their own tests.run_watchedis a template that nothing instantiates, so it has never been compiled. The PR body says these are "the screen judgements a step makes", but no step makes them. Either say in the body which later PR (outside this chain) wires them in, or move them to that PR. Upstream will not take unused helpers. - Comments name a lab run.
Engine/Pokemon_CoveredWatch.h:9("the PLZA 03.08 catch (2026-11-14) read a missed ... banner") andEngine/Pokemon_FrameCoverage.h:9("ConvertFrame at 150 ms mean, PLZA 03.08 on 2026-11-14"). Describe the failure mode, e.g. "under CPU load the pivot can hand over the same frame for a second", and move the run and date to the PR description (user theme T3).
Medium
Pokemon_SceneJudges.h:30WarpSeen::banner:""means "no banner". That is a sentinel. Usestd::optional<std::string>;any()anddescribe()then read it directly.Pokemon_SceneJudges_Tests.cpptest_talk_over():Rowis positional ({"5 s of quiet ends it", {}, repeat(QUIET, 8), SceneMove::DONE, 5}). It is not the name / input / expectation shape the other suites in this PR use (WatchCase,CoverageCase). Use nestedInput/Expectationwith designated initializers.SceneJudgesCase(a function pointer asInputand an emptyExpectation) is that shape in name only.
Low
Pokemon_SceneJudges.h:38note_warp(..., const std::string& banner_read): a read-only string should bestd::string_viewby value.Pokemon_TestExpect.his a shared header with one user (Pokemon_SceneJudges_Tests.cpp).CommonTools/ScreenEvents/ScreenEvents_Tests.cpp:29(#534) defines its ownexpect_equalwith the same signature. Keep one: CommonTools cannot include a Pokemon header, so a shared copy would have to live under CommonTools or Common/Cpp/TestRunners.Pokemon_SceneJudges.h::92, the comment onTalkOver::describe(), gives "black fade, banner read" as an example, but the code prints "black back up, banner read" or "black still down, ...". Make the comment match.
Checked: brace style, no std::filesystem/std::thread/std::mutex, CRLF kept, every new file is in SourceFiles.cmake, and WarpFade/fade_in/warp_fade_name come from the parent #534.
# Conflicts: # SerialPrograms/cmake/SourceFiles.cmake
… describe the fault The talk-over table names its fields (nested input and expectation), and the scene judge cases are plain named tests. The covered watch and frame coverage headers describe the missed-banner fault instead of the run that found it.
|
Review fixes, tip Fixed: 2 (run and date out of both headers; the run is in the description), 4 (talk-over rows use nested input/expectation with designated initializers; SceneJudgesCase is a plain named test), 7 (describe() comment). |
CoveredWatcher and its tests stay; judge_watch() reads its coverage.
|
Second fix round, tip |
The catch stop's banner watch (fork #563) runs a press under a covered watch; the helper belongs with CoveredWatcher and judge_watch().
# Conflicts: # SerialPrograms/Source/Pokemon/AutoStory/Pokemon_AutoStory_Tests.h
PLZA's throw watches with run_until() plus a short extra wait; TalkOver stays.
Depends on #536
Adds the screen judgements a step makes over time: frame coverage (which frames a watch actually inspected, and whether they are enough to say a screen did not show), a watcher wrapper that records it for judge_watch(), and the scene judges (a warp is a fade or the arrival banner; a talk or scene is over after a quiet overworld). The coverage check comes from the PLZA 03.08 catch (2026-11-14), where a missed banner under CPU load read as no banner. Tests: the FrameCoverage, CoveredWatch and SceneJudges suites, built and run by Fork Draft CI. Part of the re-split of #522/#524/#525 into reviewable steps; review fixes are new commits on the PR that owns each problem, merged up the chain.