Repository navigation
Conversation
This was referenced Nov 15, 2026
Owner
Author
|
API review (claude-sonnet-5-5) at 9ffeed3: LGTM_with_nits No correctness bugs found. I traced the cycle, bracket watch, species tally, road stops and after-throw cases against the code and the tables agree with it. What remains is comment content: several comments cite lab runs and "the user", which the review guide says belong in the PR description, plus a few small readability nits.
|
# Conflicts: # SerialPrograms/Source/Pokemon/AutoStory/Engine/Pokemon_CoveredWatch.h
REGISTERED_BANNER_EXTRA_WAIT replaces the covered-watch limits; their frame-coverage tests go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #562
Adds the decisions of a Wild Zone 1 catch that need no console: which Pokemon to target and when to throw (
CatchPlan,SpeciesCheck, the Zone 1 road positions), when a throw's result has been seen (CatchStop), and the lock-on watch.CatchStopneeds the sharedrun_watched()andWatchLimitsback inPokemon_CoveredWatch.h: they were left out of #537 because nothing called them yet. The catches in #564 call all of it. Tested byPokemonLZA::AutoStoryCatchPlanandPokemonLZA::AutoStoryCatchStop, on recorded readings with no frames.