Repository navigation
Conversation
Owner
Author
|
API review (claude-sonnet-5-5) at 3991a6f: changes_requested The unused
|
…ew fixes The lock-on and party-bar suites read frames not on CommandLineTests yet; they now skip when an image is missing (PendingFixtureTest) instead of failing. The party-bar test leaves its unused parameters unnamed (MSVC C4100), near/far become near_offset/far_offset (Windows macros), PartyBarDetector takes PARTY_SIZE and an explicit constructor, and two comments say what the code and frames are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #545
Adds two PokemonLZA screen readers that the AutoStory catches need: the lock-on bracket around a targeted Pokemon (
LockOnBracketDetector) and the party bar's species count (PartyBarDetector). Neither presses anything; both read one frame. They are first called by the Wild Zone 1 catches in #563 and #564. Tested by their image suitesPokemonLZA::LockOnBracketDetectorandPokemonLZA::PartyBarDetectoron frames inCommandLineTests/PokemonLZA/(theLockOnBracketDetectorandPartyBarDetectorfolders are not on PokemonAutomation/CommandLineTests yet).