Repository navigation
Conversation
Owner
Author
|
API review (claude-sonnet-5-5) at 49a1288: LGTM_with_nits No bugs or hard-rule violations found. The Qt, filesystem and concurrency rules are respected, control-flow formatting is right, and the test shape follows the linter's mandated form. The remaining issues are comment content that talks about development history instead of the code, a possible off-by-one in the plate-bar bounds, a stale header comment, and some small hygiene items.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #555
Adds the AutoStory detectors that tell where a story scene is: the arrival platform, the skip prompt, the autosave badge, the controls hint, the advance arrow, the main mission banner and its complete card, the minimap's wild zone, and the caught mark on a Pokemon's plate, with the pixel-share helpers they share. The platform detector compares against reference cells in
ReferenceData/plza-platform.json, whichcmake/EmbedTextFiles.cmakebuilds into the program, so no resource file is added. The program reads them through its backend in #559.PokemonLZA::AutoStoryDetectorsruns all of them together on synthetic frames and on the console frames inCommandLineTests/PokemonLZA/AutoStoryDetectors/, checking that each frame fires exactly the detectors it should; this is why they come as one PR, over the size the rest of the chain keeps to.