Repository navigation
Conversation
Owner
Author
|
API review (claude-sonnet-5-5) at df1065e: changes_requested The readers are tidy and the synthetic cases check out against the thresholds. The main problem is that the console-frame tests are registered unconditionally while their fixtures are not in CommandLineTests yet. The rest are style items: a new -1 sentinel, a comment that disagrees with the code, undocumented thresholds, and untested new detectors.
|
…ng; comment fixes Test_ConfirmChoicesFrames and Test_DialogChoiceRowsFrame register through add_pending_fixture_test(), so a CommandLineTests checkout without the new folders skips them. The minimap comment says why 140, the tutorial-card comment reads as a sentence, and the Dex banner header drops its tuning statistics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #556
Adds the AutoStory readers for text and choices: the dialog box while its text is still typing (
DialogDetector::detect_box()), the choice menu and its highlighted row, the new game's "Confirm Choices" screen, the objective marker on the minimap, the tutorial card and the Pokedex "Registered" banner. The screen events (#558), dialogs (#559) and catches (#564) call them. Tested byPokemonLZA::AutoStoryDialogChoiceBox,AutoStoryConfirmChoicesReaderandAutoStoryObjectiveMarkerReader, on drawn frames and on console frames (theAutoStoryConfirmChoicesandAutoStoryDialogChoicesfolders are not on PokemonAutomation/CommandLineTests yet).