Repository navigation
Conversation
This was referenced Nov 15, 2026
Owner
Author
|
API review (claude-sonnet-5-5) at 6bf83fe: LGTM_with_nits No bugs or hard-rule violations found. The findings are comments written around lab runs and fixtures, a stale header reference, include order, and two small readability nits.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #557
Adds what the PLZA backend reports to the shared story engine: the names of its screen readings, its failure classes (which part of a step failed, for the run report), and the adapter from its detectors to the shared screen events. This is the vocabulary the backend (#559) and the scene machine (#560) are written in. Tested by
PokemonLZA::AutoStoryFailuresandPokemonLZA::AutoStoryScreenEvents, the latter on console frames inCommandLineTests/PokemonLZA/AutoStoryDetectors/.