Repository navigation
Conversation
This was referenced Nov 15, 2026
Owner
Author
|
API review (claude-sonnet-5-5) at 22d8882: changes_requested Two behavior problems and several style points.
|
…_looks; review fixes observe() saved a PNG on every change of the look's events and every 2 s with no way to turn it off; it now saves only with StoryEnv::capture_looks (off by default). fight_battle_in_progress() waits for the next frame instead of reading an empty snapshot. The heading reading is normalized to [0, 360) with a static_cast, and talk_through_map_screen()'s header says what the code does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #558
Adds
PlzaConsoleBackend, PLZA's implementation of the shared story backend: it looks at the screen through the detectors, presses buttons, fights and saves. It comes with the console routines it calls, which call it back: dialogs, scenes, battles (run_battle_until()inPokemonLZA_TrainerBattle) and the save through the menu; this cycle is why the PR is over the size the rest of the chain keeps to. The story game in #568 wires the backend into the engine. Tested byPokemonLZA::AutoStoryDialogs; the backend itself runs only on a console, and the engine tests in #568 drive the same steps through a fake backend.