Repository navigation
Conversation
This was referenced Nov 15, 2026
Owner
Author
|
API review (claude-sonnet-5-5) at 2d7259d: LGTM_with_nits No correctness or hard-rule problems found. Brace style, the no-Qt, filesystem and concurrency rules, and the CMake source list all look fine. The remaining notes are comment hygiene, magic numbers, positional bools in test rows, duplicated test helpers and one test-registration placement. Line numbers are approximate.
|
# Conflicts: # SerialPrograms/cmake/SourceFiles.cmake
… menu save behind a switch MENU_SAVE_AT_CHECKPOINT_END stays off: the engine does not menu-save yet, as before (user decision). run_checkpoint() takes no save point.
"menu" is gone from the plans, so MENU_SAVE_AT_CHECKPOINT_END, the menu-save path of StoryGame::save and story_row_saves() go. A row that does not end on a seen autosave fails its save as "no_autosave" (as "menu_save_off" before). The table tests follow the plans: autosave rows as the run logs show them, unverified ones apart, reloads only on 02.07, 03.02 and 03.04.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #567
Adds the PLZA story game: every step name of the checkpoint plans mapped to its handler on the backend, the story table read from the plan files built into the program (
cmake/EmbedTextFiles.cmake), and segment runs with their boundary reloads.PokemonLZA_AutoStoryGame.cppis the one place that ties the actions of #559 to #564 to the plans, which is why this PR is over the size the rest of the chain keeps to. Tested byPokemonLZA::AutoStory_StoryTable(every checkpoint parses and lints, rows and saves as expected),AutoStoryEngine(each checkpoint's steps through a fake backend),AutoStorySceneMachineandAutoStoryGateWalk.