Repository navigation
Conversation
Owner
Author
|
API review (claude-sonnet-5-5) at 4cf3a21: changes_requested One real bug: walk_until holds a full 250 ms slice even when fewer ms remain, so the last leg overshoots its time. The rest is style: the heading turn may not be normalized, output parameters in the validator, a header comment that contradicts the code, repeated magic numbers, a stray
|
walk_until() held a full 250 ms slice even when less of the last leg was left, so a 1200 ms leg walked 1250 ms and a 100 ms leg 250 ms, and the log counted the full slice. It now holds min(HOLD_SLICE, what is left). The heading turn says why a difference past 180 needs no normalizing (the stick's direction wraps), and check_can_walk()'s comment matches its code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #560
Adds the overworld walks: timed legs of the left stick turned by the minimap's heading, the screen checks that end a walk early (a fade, a dialog, an A prompt), and PLZA's checks of a walk step's arguments beyond their types, run when the plans are linted. The story game in #568 calls them for every "walk" step. They are tested through the engine tests in #568 (
PokemonLZA::AutoStoryEngine), which run the walks of the built-in checkpoints against a fake backend.