Repository navigation
Conversation
…nd the zone gate walk
Owner
Author
|
API review (claude-sonnet-5-5) at e385cc2: LGTM_with_nits No bug or hard-rule violations found. The findings are comment content (a stale doc, history and lab-run talk, garbled text), a few unexplained literals, and one wasted final press in confirm_new_game_choices.
|
reset_game_from_home() answers the backup save's arrow and the dialogs itself. StartLoad keeps StartSave.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #561
Adds the steps around a checkpoint's start and Wild Zone 1's gate: loading the start save (or the backup save) and checking where it put the player, launching the game from HOME, picking Ready! on the new game's Confirm Choices, and the walk through the zone gate steered by the gate's pillars (
ZoneGateReader). The story game in #568 calls them. Tested byPokemonLZA::AutoStoryStartLoadandPokemonLZA::AutoStoryZoneGateReader(console frames inCommandLineTests/PokemonLZA/AutoStoryDetectors/Zone1Gate/); the gate walk's tests read checkpoint 03.06 and come in #568.