Repository navigation
Conversation
Owner
Author
|
API review (claude-sonnet-5-5) at 3425ba2: LGTM_with_nits Data-only change with no code. Two things need a look: provenance and run-log notes in the
|
The why and source strings drop console, date, run id, log line, fixture path and split notes and keep the reason (what the screen does and why the timing or heading holds).
…3.07 end on the game's save The step numbers refer to the recording, which is not in the repo. 03.05: the heal writes the game's own save at the counter, 03.06's start, so the program's menu save would only write the same spot again. 03.07: each catch autosaves, so the program does not save either. 03.08 says what a rerun starts from: its own start, 03.07's last catch save; the counter save is 03.05's heal and stops being the backup once 03.07 has caught.
… 03.06's, and reruns from 03.06 03.07's catches autosave past its start, so the backup save holds 03.06's counter save. No plan field states a reset checkpoint; the note says it.
[Autosave] seen at the end of 03.01, 03.03, 03.05, 03.07, 03.08 and 03.09; 03.10 is unverified; 03.02, 03.04, 03.06 and 03.11 drop "menu". 03.01 and 03.11 no longer reload when chained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #566
Adds the checkpoint plans of Main Mission 03 as data, 03.01 to 03.11: down to the lobby, Taunie's battle, over the rooftops, the Pokemon Center and the Pokedex, Wild Zone 1's catches, the Research Lab and Mable's Rock Smash TM. Nothing reads them until #568 builds the plan files into the program and its table tests lint every step against the game's actions.