Skip to content

PokemonLZA AutoStory: Main Mission 03 checkpoint plans - #567

Draft
dayfine wants to merge 11 commits into
plza/upstream/m2-01from
plza/upstream/m3-01
Draft

dayfine wants to merge 11 commits into
plza/upstream/m2-01from
plza/upstream/m3-01

Conversation

@dayfine

@dayfine dayfine commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Depends on #566

Adds the checkpoint plans of Main Mission 03 as data, 03.01 to 03.11: down to the lobby, Taunie's battle, over the rooftops, the Pokemon Center and the Pokedex, Wild Zone 1's catches, the Research Lab and Mable's Rock Smash TM. Nothing reads them until #568 builds the plan files into the program and its table tests lint every step against the game's actions.

@dayfine

dayfine commented Nov 15, 2026

Copy link
Copy Markdown
Owner Author

API review (claude-sonnet-5-5) at 3425ba2: LGTM_with_nits

Data-only change with no code. Two things need a look: provenance and run-log notes in the why fields, and an inconsistent reload_when_chained value in 03.04. Cross-file consistency otherwise holds (place and spot starts, save modes, shared walk_to_zone_gate_entrance use). I could not check against the plan schema or the action table, which land in #568.

  • [style] SerialPrograms/Source/VideoGames/PokemonLZA/Programs/AutoStory/StoryData/plza-03.04.plan.json:44 reload_when_chained is the string "always" here but the boolean true in 03.01, 03.02 and 03.11. If the loader reads a bool, this plan fails to parse or silently takes the default. If "always" is a distinct mode, it is undocumented and unexplained in this PR. Fix: Confirm the schema accepts both forms. If "always" means the same as true, use true. If it is a separate mode, say so in the event or checkpoint notes, or give it a name that does not collide with the boolean.
  • [style] SerialPrograms/Source/VideoGames/PokemonLZA/Programs/AutoStory/StoryData/plza-03.08.plan.json:14 The why text carries run history and provenance instead of describing what the game does. It cites "console B 2026-11-14 19:36", "as before" and "the tally decides as before", and it is a very long paragraph. 03.06 (to_zone_1_gate, a fixture path and a timestamp), 03.10 (a log line in metadata.source) and 03.11 (to_mable: "r6, r7", "was written 270") do the same. Review guidance says comments should not refer to lab runs, branches or earlier behaviour. Fix: Trim each why to what the screen or action does and why the chosen timing or heading is correct. Move dates, run ids, log lines and fixture paths to the PR or commit message, or to a separate notes field.
  • [nit] SerialPrograms/Source/VideoGames/PokemonLZA/Programs/AutoStory/StoryData/plza-03.06.plan.json:27 Three consecutive legs at heading 0 ([[0, 2000], [0, 3000], [0, 6000]]) are one 11 s straight walk, and the split is not explained. The why says the first 2 s replace a dash test but does not account for the 3 s and 6 s legs. Fix: Merge into [[0, 11000]], or add a short note on why each leg boundary matters (for example a camera or heading checkpoint).

The why and source strings drop console, date, run id, log line, fixture
path and split notes and keep the reason (what the screen does and why the
timing or heading holds).
…3.07 end on the game's save

The step numbers refer to the recording, which is not in the repo.
03.05: the heal writes the game's own save at the counter, 03.06's start,
so the program's menu save would only write the same spot again.
03.07: each catch autosaves, so the program does not save either.
03.08 says what a rerun starts from: its own start, 03.07's last catch
save; the counter save is 03.05's heal and stops being the backup once
03.07 has caught.
… 03.06's, and reruns from 03.06

03.07's catches autosave past its start, so the backup save holds 03.06's
counter save. No plan field states a reset checkpoint; the note says it.
[Autosave] seen at the end of 03.01, 03.03, 03.05, 03.07, 03.08 and 03.09; 03.10 is unverified; 03.02, 03.04, 03.06 and 03.11 drop "menu". 03.01 and 03.11 no longer reload when chained.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant