Repository navigation
Conversation
This was referenced Nov 15, 2026
Owner
Author
|
API review (claude-sonnet-5-5) at 2ca4fa4: changes_requested One correctness bug: walk_from_objective() has the misread filter that walk_to_objective() was fixed to avoid. The rest is style: duplicated camera-steering code, misplaced comments, PR/lab-run references in comments, a stub function, and marker walks split across two files with circular includes.
|
…nceReads walk_from_objective() kept the first read and dropped any read more than 12 from it, so a misread first read (36 as "3", 110 as "1110") rejected every true read after it, and a high one could end the walk early. DistanceReads moves from Catches.cpp to MarkerWalks.h and both walks use it. Also: Catches.h's header sentence is finished, MARKER_SCENE_WAIT is Milliseconds, and the camera-pitch comment names level_camera().
…tra wait Callers only tested for a seen banner; it now returns that bool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #563
Adds the catches of Main Mission 03: the catch tutorial, a battle then a catch, catching new species in Wild Zone 1 until the Pokedex has five, and the walks by the objective marker into and out of the zone.
PokemonLZA_AutoStoryCatches.cppalone is over the size the rest of the chain keeps to; it is one routine with its retries. The story game in #568 wires these into steps of 03.07 and 03.08. They run only on a console; their decisions are tested in #563.