Repository navigation
Conversation
Owner
Author
|
API review (claude-sonnet-5-5) at aeddc3b: LGTM_with_nits Data-only change with no correctness bugs visible from the diff. The
|
The why and source strings drop console, date, renumbering and earlier-value notes and keep the reason. 01.02 says its 0 ms leg only turns and that the sidestep's 1000 ms is not measured yet.
The step numbers refer to the recording, which is not in the repo; each why keeps what the event does. 01.03's "choose it" names Chikorita.
… none No run log shows [Autosave] at the end of 01.00-01.02, so they are "unverified"; 01.02 no longer reloads when chained. 01.03 drops "menu".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #564
Adds the checkpoint plans of Main Mission 01 as data: 01.00 (a new game from Confirm Choices to the station platform), 01.01 (the platform to the mission), 01.02 (Pancham's chase) and 01.03 (the starter and Andi's battle). Each file lists the checkpoint's steps, its start place and its save. Nothing reads them until #568 builds the plan files into the program and its table tests (
PokemonLZA::AutoStory_StoryTable) lint every step against the game's actions.