Skip to content

PokemonLZA AutoStory: Main Mission 02 checkpoint plans - #566

Draft
dayfine wants to merge 10 commits into
plza/upstream/m1-01from
plza/upstream/m2-01
Draft

dayfine wants to merge 10 commits into
plza/upstream/m1-01from
plza/upstream/m2-01

Conversation

@dayfine

@dayfine dayfine commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Depends on #565

Adds the checkpoint plans of Main Mission 02 as data, 02.01 to 02.07: from the Battle Zone to Brigitte, then to Hotel Z, the check-in, the elevator to Room 202, the night and the first evening. Nothing reads them until #568 builds the plan files into the program and its table tests lint every step against the game's actions.

@dayfine

dayfine commented Nov 15, 2026

Copy link
Copy Markdown
Owner Author

API review (claude-sonnet-5-5) at f56491c: changes_requested

Data-only PR; the step data looks internally consistent. Two things need fixing. 02.06 omits reload_when_chained, which every other chained checkpoint sets. The why and source strings narrate lab runs, renumbering and earlier versions instead of describing the game, which the review guide treats as blocking.

  • [bug] SerialPrograms/Source/VideoGames/PokemonLZA/Programs/AutoStory/StoryData/plza-02.06.plan.json:49 execution has no reload_when_chained, but 02.02, 02.03, 02.04, 02.05 and 02.07 all set it. 02.06 starts from an autosave in Room 202, just as they start from autosaves. The omission looks left over from the renumbering, and chained runs would then skip the reload before this stretch. Fix: Add "reload_when_chained": true to execution, or state why the room autosave needs no reload.
  • [rule] SerialPrograms/Source/VideoGames/PokemonLZA/Programs/AutoStory/StoryData/plza-02.04.plan.json:26 This why is an essay on lab runs and history: "the old turn to AZ is gone", "the scene ended at ~76 s, then a minute of blind A", and "(autosave B)". It talks about earlier versions and console runs rather than what the screen does, and the wording is unclear. It is also one very long line. Fix: Keep only the game-side reasoning: no free control between the clerk and the elevator, the party bar has no D-pad hint, so the step ends on 5 s quiet, and the opening is ~17 s without text, hence the 30 s minimum. Move run timings and history to the PR description.
  • [rule] SerialPrograms/Source/VideoGames/PokemonLZA/Programs/AutoStory/StoryData/plza-02.05.plan.json:60 The source string records lab results ("02.04 from there failed at talk_to_clerk") and split history. That is about our runs, not a durable description of the data. Fix: Trim source to where the checkpoint starts and ends. Put the failure history in the PR description or commit message.
  • [style] SerialPrograms/Source/VideoGames/PokemonLZA/Programs/AutoStory/StoryData/plza-02.06.plan.json:47 source says "Renumbered from 02.05 when 02.04 was split". That is branch and PR history, not information about the checkpoint. Fix: Remove the renumbering note. The same applies to the renumbering and "split from ..." chains in 02.07's source (line 29), 02.03 (line 29) and 02.02 (line 66).
  • [style] SerialPrograms/Source/VideoGames/PokemonLZA/Programs/AutoStory/StoryData/plza-02.04.plan.json:16 The second leg [-85, 0] has zero duration and is an unexplained magic value. The why only explains the 2.5 s leg, so the reader cannot tell whether it is a turn-in-place. Fix: Say in the why that the 0 ms leg only turns to face the clerk, or fold the turn into the preceding leg.
  • [nit] SerialPrograms/Source/VideoGames/PokemonLZA/Programs/AutoStory/StoryData/plza-02.02.plan.json:29 The why mixes two dated console runs (2026-11-10, 2026-11-13) and a before/after-battle comparison. This is lab narration that will go stale. Fix: State the invariant: the street scene can end at the gate or at the near end of the street, so walk_to_prompt covers both. Drop the dates.

… source say what, not when

02.06 starts from the Room 202 autosave like 02.02-02.05 and 02.07, but
had no reload_when_chained, so a chained run went on from wherever 02.05
left the player. The why and source strings drop console, date, split
and renumbering notes and keep the reason; 02.04 says its 0 ms leg turns
to the clerk.
The step numbers refer to the recording, which is not in the repo; each
why keeps what the event does. 02.06's bare "yes" says what it answers.
…unverified

Run logs show [Autosave] only at the end of 02.06. Only 02.07 still reloads when chained (after 02.06's autosave).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant