Repository navigation
Conversation
This was referenced Nov 15, 2026
Owner
Author
|
API review (claude-sonnet-5-5) at 5682449: LGTM_with_nits No correctness bugs found in the scene machine logic. The findings are design and readability: failure kinds recovered by parsing message text, parallel per-screen tables, an unexplained magic-number cluster, and a repetitive describe_look. There are also a few include and comment nits. The machine's tests only arrive in #568, so none of this is exercised in this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #559
Adds the scene machine: the loop that presses through a story scene (text, choices, cards, fades, banners) until the player has control again, deciding on each look from the screen events, with a quiet time and a timeout that fail the step. The story game in #568 runs every scene step through it. Its tests,
PokemonLZA::AutoStorySceneMachine, run it on event sequences against the built-in checkpoints and so come with the story game in #568.