Repository navigation
Conversation
The user approved four Mart stops to fill the gaps against PokeGuy's bags (PokemonSimulation docs/battles/pokeguy-conditions.md): - 12.03: 4 Super Potions at Fuchsia's Mart after Koga, the last Fuchsia visit before Silph Co.; the walk is 12.01's, and the Super Repel moves after it, before the Fly. - 18.03 (new row between 18.02b and 17.02): Fly to Celadon for 2 X Accuracies at the Department Store's 5F, Fly back to Saffron's Center. - 19.01a: an Antidote and 2 Parlyz Heals at Viridian's Mart, its own step. - 20.01a: 2 Full Heals after the 13 Full Restores, with the new MART arg if_affordable: a line the money doesn't cover is skipped, logged. heal_to_full() uses a Hyper Potion from the bag for more than a Super Potion heals. The golden's new 12.03 and 18.03 lines are 12.01's and 10.01's where the legs repeat; 18.03's walk from Celadon's Fly landing to the store is predicted, to be checked against CI's golden output.
… rides the store lift 18.01 starts on Saffron Gym's door mat, but 16.06 ends at Saffron's nurse and no row walked between them (console B, 2026-11-15: 18.01's first leg moved nothing twice against the Center's counter). 16.06b walks out of the Center and through Saffron City in legs held to walls, to (46, 13) and in through the Gym's door. 18.01 leaves the unauthored-start list, so the story's chain tests now check 16.06 to 18.01; a new sim test checks the 16.06 end pose to 18.01 start pose chain through 16.06b. 18.03's sim test gives the sim the Department Store lift's room and floors, as 10.01's test does.
16.06 walked back down Silph Co. by the pads and stairs to Saffron's Center, about 2 minutes with 16 tiles walked again after re-plans, and 18.02b walked about 80 tiles round Saffron's blocks from the Gym's door to the Center for a straight line of 48 (console B, 2026-11-15). 16.06 now uses an Escape Rope from 11F (SilphCo_11F allows it: pokefirered map.json allow_escaping), which lands below Silph Co.'s door (33, 31), and flies to the Center's door; 18.02b walks only out of the Gym's door and flies. 18.02b starts with silph_cleared, as 16.06b, so a run from its save plans without the Rocket on (46, 13). 16.06b, the Center to the Gym's door, drops the box by row 41 (about 79 tiles) for four legs: row 40 to the east wall, column 52 to row 14's wall, west to column 46 and north through the Gym's door, 62 tiles where the map allows no fewer than 58. New sim tests check that each stretch of these rows' walks stays within 1.2 times its straight line, plus what the map forces, and crosses no tile twice. The 16.06 sim test models the rope's warp, and the 18.02b one runs the Fly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #578 (base frlg/boss-policy; the diff shows only this change).
The story's bag fell short of PokeGuy's at several bosses (PokemonSimulation docs/battles/pokeguy-conditions.md), and the user approved four Mart stops on 2026-11-15. 12.03 buys 4 Super Potions at Fuchsia's Mart after Koga (12.01's walk and Cut tree, the Super Repel moved after it); a new row 18.03 between 18.02b and 17.02 flies to Celadon for 2 X Accuracies on the store's 5F and flies back to Saffron's Center, so the current save (past Celadon) still gets them; 19.01a buys an Antidote and 2 Parlyz Heals at Viridian in a step of its own; 20.01a keeps the 13 Full Restores and adds 2 Full Heals with a new MART arg,
if_affordable, which skips a line the money doesn't cover with a log line instead of failing.heal_to_full()now uses a Hyper Potion from the bag for more than a Super Potion heals. There's no Trainer Card money reader, so nothing reads the money at 16.06.Tested by the Mart tests (fake Mart with
if_affordable, and a test that each approved step is in place before its boss and buys its lines), the Healing tests, a Saffron Gym sim test for 18.03, and the updated plan golden; nothing ran on a console. The golden's 12.03 and 18.03 legs are copied from 12.01 and 10.01 where they repeat, but the walk from Celadon's Fly landing to the store is a guess until CI's golden test confirms it.