Skip to content

BBQ Farmer: let the exclusions table reroll quests the farmer cannot do - #9

Closed
dayfine wants to merge 2 commits into
bbq/verified-rerollfrom
bbq/unsupported-quest-rerolls
Closed

dayfine wants to merge 2 commits into
bbq/verified-rerollfrom
bbq/unsupported-quest-rerolls

Conversation

@dayfine

@dayfine dayfine commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Fork-only PR, moved from upstream PokemonAutomation#1644 until its parents merge. Based on bbq/verified-reroll, so the diff shows only this change. Parents: #8 → PokemonAutomation#1640 (upstream).

The farmer can't do some quests: pickup, and the flying photo and flying catch quests. plan_quests() dropped those before it looked at the exclusions table, so a reroll row for one of them did nothing, and the quest kept blocking its slot. Pickup couldn't be picked in the table at all.

Change

  • The table is applied first. Reroll and skip rows now work for quests the farmer can't do. A run row for one of them is ignored, since there is no route for it.
  • Pickup is listed in the table.
  • Cheaper fallback. When nothing can be done and nothing was rerolled, the farmer rerolls the first quest it can't do that has no table row, which costs one reroll instead of three or four. If there is no such quest, it rerolls every quest, as before.

Rerolls go through #8, which checks which quest it pays for and that the quest was replaced.

Tests

6 new PokemonSV::BBQuestPlan cases:

  • a reroll row on a quest the farmer can't do
  • a run row on one
  • a skip row on one, so it isn't used for the fallback
  • the one-quest fallback
  • reroll-all when there's no quest to fall back on
  • an undetected quest, which isn't treated as one the farmer can't do

One existing case ("nothing doable rerolls all") now expects the one-quest fallback. All 23 BBQ cases pass.

Earlier, Codex validated the same idea live: rerolling pickup in the third row while other quests stayed runnable, at 10 BP. That version is kept in the local branch backup/unsupported-quest-rerolls-codex.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

plan_quests() dropped quests the farmer cannot do (pickup, flying photo
and catch) before looking at the exclusions table, so a reroll row for
one of them did nothing: the quest stayed on the panel and blocked the
slot. Pickup could not be picked in the table at all.

The table is now applied first. Reroll and skip rows work for quests the
farmer cannot do; a run row for one is ignored, since there is no route
for it. Pickup is listed in the table.

With nothing to do and nothing rerolled, the first quest the farmer cannot
do that has no table row is rerolled instead of every quest, which costs
one reroll instead of three or four. Every quest is still rerolled when
there is no such quest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Brings in the default member initializers for its test scenario fields.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine

dayfine commented Oct 27, 2026

Copy link
Copy Markdown
Owner Author

Closing: superseded. The farmer now always rerolls quests it can't do (lab commit ec648a9), so the exclusions-table option isn't needed. Tracked in the PR plan as part of the quest-policy PR.

@dayfine dayfine closed this Oct 27, 2026
dayfine added a commit that referenced this pull request Oct 30, 2026
The base was rebuilt since this branch forked: the stack under it was
re-merged onto main, the exclusions-table reroll (fork #9) was dropped, and
the BBQ tests moved to Programs/Farming/PokemonSV_BBQTests.cpp. Took the base
for everything except this PR's own change (7dfc056 + f4d4c47), which is
re-applied on top: reroll_quest() returns its verified read and 3-slot reads
are reusable when the panel had 3 slots; run_bbq_rounds() seeds the next plan
from it unless the round saved, and always reuses the scheduling panel for the
first dispatch, next to the base's doable-read guard and failed-quest filter.
Its tests moved into PokemonSV_BBQTests.cpp; the simulated process_quest_list()
keeps the base's out_of_bp, and the base-only round scenarios drop the read
before each round's first dispatch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant