fix: pin monitor YAML snapshot to known update fields - #111
Open
caballeto wants to merge 1 commit into
Open
Conversation
Required<UpdateMonitorRequest> breaks CLI typecheck after spec regen adds optional keys. Pick the YAML-managed fields so additive DTO properties stay non-events. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MonitorSnapshotwasRequired<UpdateMonitorRequest>. After mono#1040the spec grewcapturePolicy,fastRetryMaxAttempts,package, andstatus, and Spec Evolution Harness regen failshandlers.ts.Picks the YAML-managed keys so additive optional update fields do not break constructors.Test plan
npm run typecheckmain(mono clones CLI main)Made with Cursor