Skip to content

fix: pin monitor YAML snapshot to known update fields #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caballeto wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: pin monitor YAML snapshot to known update fields #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions src/lib/yaml/handlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,10 +703,28 @@ const resourceGroupHandler = defineHandler<YamlResourceGroup, Schemas['ResourceG

// ── Monitor ─────────────────────────────────────────────────────────────

// Derived from UpdateMonitorRequest minus control-only fields (clearAuth,
// clearEnvironmentId, managedBy) that are mutation signals, not state.
// auth and incidentPolicy need | null because monitors can lack them.
type MonitorSnapshotBase = Required<Omit<Schemas['UpdateMonitorRequest'], 'clearEnvironmentId' | 'clearAuth' | 'managedBy'>>
// YAML-managed update fields only. Do not Required<> the whole UpdateMonitorRequest
// — additive optional keys (capturePolicy, package, status, …) must not break
// snapshot constructors after spec regen (evolution harness).
type MonitorSnapshotKeys =
| 'name'
| 'config'
| 'frequencySeconds'
| 'enabled'
| 'regions'
| 'environmentId'
| 'assertions'
| 'auth'
| 'incidentPolicy'
| 'alertChannelIds'
| 'tags'
type MonitorUpdateFields = Omit<
Schemas['UpdateMonitorRequest'],
'clearEnvironmentId' | 'clearAuth' | 'managedBy'
>
type MonitorSnapshotBase = Required<
Pick<MonitorUpdateFields, Extract<MonitorSnapshotKeys, keyof MonitorUpdateFields>>
>
type MonitorSnapshot = Omit<MonitorSnapshotBase, 'auth' | 'incidentPolicy'> & {
auth: MonitorSnapshotBase['auth'] | null
incidentPolicy: MonitorSnapshotBase['incidentPolicy'] | null
Expand Down
Loading