Repository navigation
fix(coding-agent): allow subagents with prompt URL metadata - #160
Merged
Merged
Conversation
Pepps233
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes subagent spawning in trusted Diffex checkouts where the project-local prompt URL extension is loaded. The extension now observes submitted user messages without registering an execution-mutating hook, preserving its PR, issue, and advisory metadata display while allowing
spawn_agentto proceed.Reasoning
The prompt URL extension only reads user text to update terminal UI and session metadata, so
message_startis the appropriate observation boundary. Keepingbefore_agent_startwould continue triggering the fail-closed subagent policy, while weakening that policy would allow extensions that genuinely modify prompts or context to be bypassed by child sessions. The replacement event occurs before the provider request, so the prompt metadata display remains available without changing subagent security guarantees.Changes
before_agent_startto usermessage_startevents.message_startobservation handlers permit spawning.Testing
node ../../node_modules/vitest/dist/cli.js --run test/suite/subagent-registration.test.tsnpm run check