Skip to content

fix(coding-agent): allow subagents with prompt URL metadata #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Issacboy123 merged 1 commit into from
Aug 30, 2026
Merged

fix(coding-agent): allow subagents with prompt URL metadata #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .diffex/extensions/prompt-url-widget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,9 @@ export default function promptUrlWidgetExtension(pi: ExtensionAPI) {
});
};

pi.on("before_agent_start", async (event, ctx) => {
if (!ctx.hasUI) return;
const match = extractPromptMatch(event.prompt);
pi.on("message_start", async (event, ctx) => {
if (!ctx.hasUI || event.message.role !== "user") return;
const match = extractPromptMatch(getUserText(event.message.content));
if (!match) {
return;
}
Expand All @@ -231,7 +231,7 @@ export default function promptUrlWidgetExtension(pi: ExtensionAPI) {
rebuildFromSession(ctx);
});

const getUserText = (content: string | { type: string; text?: string }[] | undefined): string => {
function getUserText(content: string | { type: string; text?: string }[] | undefined): string {
if (!content) return "";
if (typeof content === "string") return content;
return (
Expand All @@ -240,7 +240,7 @@ export default function promptUrlWidgetExtension(pi: ExtensionAPI) {
.map((block) => block.text)
.join("\n") ?? ""
);
};
}

const rebuildFromSession = (ctx: ExtensionContext) => {
if (!ctx.hasUI) return;
Expand Down
6 changes: 5 additions & 1 deletion packages/coding-agent/test/suite/subagent-registration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const INCOMPATIBLE_PARENT_HOOKS = [
"message_end",
] as const;
type IncompatibleParentHook = (typeof INCOMPATIBLE_PARENT_HOOKS)[number];
type ObservationParentHook = "agent_start" | "after_provider_response" | "tool_execution_start";
type ObservationParentHook = "agent_start" | "after_provider_response" | "message_start" | "tool_execution_start";

function registerParentHook(api: ExtensionAPI, hook: IncompatibleParentHook | ObservationParentHook): void {
switch (hook) {
Expand Down Expand Up @@ -81,6 +81,9 @@ function registerParentHook(api: ExtensionAPI, hook: IncompatibleParentHook | Ob
case "after_provider_response":
api.on("after_provider_response", () => {});
break;
case "message_start":
api.on("message_start", () => {});
break;
case "tool_execution_start":
api.on("tool_execution_start", () => {});
break;
Expand Down Expand Up @@ -389,6 +392,7 @@ describe("root subagent tool registration", () => {
const observed = await createPolicyRoot(harness, [
"agent_start",
"after_provider_response",
"message_start",
"tool_execution_start",
]);
await getActiveTool(observed.session, "spawn_agent").execute("spawn", { name: "worker", task: "task" });
Expand Down
Loading