feat(manipulation): add trajectory parametrization - #3287
Open
TomCC7 wants to merge 35 commits into
Open
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #3287 +/- ##
==========================================
+ Coverage 74.86% 74.95% +0.08%
==========================================
Files 1137 1144 +7
Lines 109071 109571 +500
Branches 9838 9868 +30
==========================================
+ Hits 81661 82131 +470
- Misses 24618 24639 +21
- Partials 2792 2801 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
TomCC7
commented
Jul 30, 2026
…ization # Conflicts: # dimos/manipulation/manipulation_module.py
TomCC7
marked this pull request as ready for review
July 30, 2026 19:17
TomCC7
requested review from
Dreamsorcerer,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
July 30, 2026 19:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes DIM-1093
Contribution path
Problem
Manipulation planners return either an untimed geometric path or a planner-native timed trajectory.
ManipulationModulepreviously owned a simple per-robot trapezoid generator and mixed path conversion, validation, plan storage, and execution concerns. The stack had no startup-selectable trajectory-parametrization boundary, no RoboPlan TOPP-RA integration, and no GUI control for reducing the speed of future plans.Solution
TrajectoryParametrizerSpecbesidePlannerSpecandWorldSpec. Its implementations convert paths, validate canonical trajectory structure, and constructGeneratedPlan.RoboPlanWorldselectsroboplan_toppraandDrakeWorldselectssimple_trapezoid; explicit configuration overrides the world default. A backend failure rejects the plan—there is no fallback.GeneratedPlan.roboplan==0.5.1. RoboPlan model composition preserves authored acceleration limits and temporarily supplies a global2.0 rad/s²limit where acceleration is absent. A TODO tracks removing this fallback when formal per-joint DimOS limit overrides are available.How to Test
Test the RoboPlan world and its default TOPP-RA backend on the stock xArm model:
Test compatibility timing by selecting the simple backend explicitly:
Selecting
roboplan_toppraexplicitly is equivalent to omitting trajectory-parametrization configuration withworld_backend=roboplan.In Viser, plan and preview a multi-waypoint motion, change Next plan speed, then plan again. The new plan should slow down; the previously accepted plan should remain unchanged.
Automated validation completed:
uv run pytest dimos/manipulation -m 'not (self_hosted or mujoco or self_hosted_large)'— 408 passed, 19 deselected±2.0 rad/s²acceleration boundsdimos/manipulationuv lock --checkgit diff --checkHardware/manual QA completed:
simple_trapezoid.RoboPlanWorldandroboplan_toppra.AI assistance
OpenAI Codex with GPT-5 was used extensively for design exploration, implementation, tests, documentation, conflict resolution, and review.
Checklist